Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: content/browser/media/android/provision_fetcher_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/provision_fetcher_impl.cc
diff --git a/content/browser/media/android/provision_fetcher_impl.cc b/content/browser/media/android/provision_fetcher_impl.cc
index 0ff1a92bbaa0c068a0fefb868ce52a0d4bc69b21..896f373622fed2b741a73d6cb9a0789557eb109d 100644
--- a/content/browser/media/android/provision_fetcher_impl.cc
+++ b/content/browser/media/android/provision_fetcher_impl.cc
@@ -9,6 +9,7 @@
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/storage_partition.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
#include "net/url_request/url_request_context_getter.h"
namespace content {
@@ -16,24 +17,20 @@ namespace content {
// static
void ProvisionFetcherImpl::Create(
RenderFrameHost* render_frame_host,
- mojo::InterfaceRequest<media::mojom::ProvisionFetcher> request) {
+ media::mojom::ProvisionFetcherRequest request) {
net::URLRequestContextGetter* context_getter =
BrowserContext::GetDefaultStoragePartition(
render_frame_host->GetProcess()->GetBrowserContext())->
GetURLRequestContext();
DCHECK(context_getter);
-
- // The created object is strongly bound to (and owned by) the pipe.
- new ProvisionFetcherImpl(CreateProvisionFetcher(context_getter),
- std::move(request));
+ mojo::MakeStrongBinding(base::MakeUnique<ProvisionFetcherImpl>(
+ CreateProvisionFetcher(context_getter)),
+ std::move(request));
}
ProvisionFetcherImpl::ProvisionFetcherImpl(
- std::unique_ptr<media::ProvisionFetcher> provision_fetcher,
- mojo::InterfaceRequest<ProvisionFetcher> request)
- : binding_(this, std::move(request)),
- provision_fetcher_(std::move(provision_fetcher)),
- weak_factory_(this) {
+ std::unique_ptr<media::ProvisionFetcher> provision_fetcher)
+ : provision_fetcher_(std::move(provision_fetcher)), weak_factory_(this) {
DVLOG(1) << __FUNCTION__;
}
« no previous file with comments | « content/browser/media/android/provision_fetcher_impl.h ('k') | content/browser/media/capture/image_capture_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698