Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Unified Diff: components/contextual_search/renderer/overlay_page_notifier_service_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/contextual_search/renderer/overlay_page_notifier_service_impl.h
diff --git a/components/contextual_search/renderer/overlay_page_notifier_service_impl.h b/components/contextual_search/renderer/overlay_page_notifier_service_impl.h
index 6b1469c85c33a502f99c7ab068eea9db88d2d4c5..b38264430bee7bd79f9c2c7a5299f91d2a1699d5 100644
--- a/components/contextual_search/renderer/overlay_page_notifier_service_impl.h
+++ b/components/contextual_search/renderer/overlay_page_notifier_service_impl.h
@@ -9,7 +9,6 @@
#include "base/memory/weak_ptr.h"
#include "components/contextual_search/common/overlay_page_notifier_service.mojom.h"
#include "components/contextual_search/renderer/overlay_js_render_frame_observer.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace contextual_search {
@@ -24,15 +23,13 @@ class OverlayPageNotifierServiceImpl
: public mojom::OverlayPageNotifierService {
public:
explicit OverlayPageNotifierServiceImpl(
- base::WeakPtr<OverlayJsRenderFrameObserver> observer,
- mojo::InterfaceRequest<mojom::OverlayPageNotifierService> request);
+ base::WeakPtr<OverlayJsRenderFrameObserver> observer);
~OverlayPageNotifierServiceImpl() override;
// Implementation of mojo interface OverlayPageNotifierService.
void NotifyIsContextualSearchOverlay() override;
private:
- mojo::StrongBinding<mojom::OverlayPageNotifierService> binding_;
base::WeakPtr<OverlayJsRenderFrameObserver> overlay_js_observer_;
DISALLOW_COPY_AND_ASSIGN(OverlayPageNotifierServiceImpl);

Powered by Google App Engine
This is Rietveld 408576698