components/contextual_search/renderer/overlay_page_notifier_service_impl.cc - Issue 2326913003: Privatize StrongBinding lifetime management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/contextual_search/renderer/overlay_page_notifier_service_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/contextual_search/renderer/overlay_page_notifier_service_impl.h ('k') | components/dom_distiller/content/browser/distillability_driver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/contextual_search/renderer/overlay_page_notifier_service_impl.cc

diff --git a/components/contextual_search/renderer/overlay_page_notifier_service_impl.cc b/components/contextual_search/renderer/overlay_page_notifier_service_impl.cc

index 79f72cb54b8185a38ebe43a98347fe0c93fd6451..c0ebfc4c607c99f17d9bf322d5ab1860d6efcb1c 100644

--- a/components/contextual_search/renderer/overlay_page_notifier_service_impl.cc

+++ b/components/contextual_search/renderer/overlay_page_notifier_service_impl.cc

@@ -11,9 +11,8 @@

namespace contextual_search {

OverlayPageNotifierServiceImpl::OverlayPageNotifierServiceImpl(

- base::WeakPtr<OverlayJsRenderFrameObserver> observer,

- mojo::InterfaceRequest<mojom::OverlayPageNotifierService> request)

- : binding_(this, std::move(request)), overlay_js_observer_(observer) {}

+ base::WeakPtr<OverlayJsRenderFrameObserver> observer)

+ : overlay_js_observer_(observer) {}

OverlayPageNotifierServiceImpl::~OverlayPageNotifierServiceImpl() {}