Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: components/contextual_search/renderer/overlay_js_render_frame_observer.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/contextual_search/renderer/overlay_js_render_frame_observer.cc
diff --git a/components/contextual_search/renderer/overlay_js_render_frame_observer.cc b/components/contextual_search/renderer/overlay_js_render_frame_observer.cc
index f0ac88b1d751a3bd555fcf2556aecaf983575bde..9214a7772b5766685ee7f07c59371826b3995f32 100644
--- a/components/contextual_search/renderer/overlay_js_render_frame_observer.cc
+++ b/components/contextual_search/renderer/overlay_js_render_frame_observer.cc
@@ -10,6 +10,7 @@
#include "components/contextual_search/renderer/contextual_search_wrapper.h"
#include "components/contextual_search/renderer/overlay_page_notifier_service_impl.h"
#include "content/public/renderer/render_frame.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
#include "services/shell/public/cpp/interface_registry.h"
#include "v8/include/v8.h"
@@ -35,8 +36,10 @@ void OverlayJsRenderFrameObserver::RegisterMojoInterface() {
void OverlayJsRenderFrameObserver::CreateOverlayPageNotifierService(
mojo::InterfaceRequest<mojom::OverlayPageNotifierService> request) {
- new OverlayPageNotifierServiceImpl(weak_factory_.GetWeakPtr(),
- std::move(request));
+ mojo::MakeStrongBinding(
+ base::MakeUnique<OverlayPageNotifierServiceImpl>(
+ weak_factory_.GetWeakPtr()),
+ std::move(request));
}
void OverlayJsRenderFrameObserver::SetIsContextualSearchOverlay() {

Powered by Google App Engine
This is Rietveld 408576698