Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: components/contextual_search/renderer/overlay_js_render_frame_observer.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/contextual_search/renderer/overlay_js_render_frame_observer .h" 5 #include "components/contextual_search/renderer/overlay_js_render_frame_observer .h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "components/contextual_search/renderer/contextual_search_wrapper.h" 10 #include "components/contextual_search/renderer/contextual_search_wrapper.h"
11 #include "components/contextual_search/renderer/overlay_page_notifier_service_im pl.h" 11 #include "components/contextual_search/renderer/overlay_page_notifier_service_im pl.h"
12 #include "content/public/renderer/render_frame.h" 12 #include "content/public/renderer/render_frame.h"
13 #include "mojo/public/cpp/bindings/strong_binding.h"
13 #include "services/shell/public/cpp/interface_registry.h" 14 #include "services/shell/public/cpp/interface_registry.h"
14 #include "v8/include/v8.h" 15 #include "v8/include/v8.h"
15 16
16 namespace contextual_search { 17 namespace contextual_search {
17 18
18 OverlayJsRenderFrameObserver::OverlayJsRenderFrameObserver( 19 OverlayJsRenderFrameObserver::OverlayJsRenderFrameObserver(
19 content::RenderFrame* render_frame) 20 content::RenderFrame* render_frame)
20 : RenderFrameObserver(render_frame), 21 : RenderFrameObserver(render_frame),
21 is_contextual_search_overlay_(false), 22 is_contextual_search_overlay_(false),
22 weak_factory_(this) {} 23 weak_factory_(this) {}
23 24
24 OverlayJsRenderFrameObserver::~OverlayJsRenderFrameObserver() {} 25 OverlayJsRenderFrameObserver::~OverlayJsRenderFrameObserver() {}
25 26
26 void OverlayJsRenderFrameObserver::DidStartProvisionalLoad() { 27 void OverlayJsRenderFrameObserver::DidStartProvisionalLoad() {
27 RegisterMojoInterface(); 28 RegisterMojoInterface();
28 } 29 }
29 30
30 void OverlayJsRenderFrameObserver::RegisterMojoInterface() { 31 void OverlayJsRenderFrameObserver::RegisterMojoInterface() {
31 render_frame()->GetInterfaceRegistry()->AddInterface(base::Bind( 32 render_frame()->GetInterfaceRegistry()->AddInterface(base::Bind(
32 &OverlayJsRenderFrameObserver::CreateOverlayPageNotifierService, 33 &OverlayJsRenderFrameObserver::CreateOverlayPageNotifierService,
33 weak_factory_.GetWeakPtr())); 34 weak_factory_.GetWeakPtr()));
34 } 35 }
35 36
36 void OverlayJsRenderFrameObserver::CreateOverlayPageNotifierService( 37 void OverlayJsRenderFrameObserver::CreateOverlayPageNotifierService(
37 mojo::InterfaceRequest<mojom::OverlayPageNotifierService> request) { 38 mojo::InterfaceRequest<mojom::OverlayPageNotifierService> request) {
38 new OverlayPageNotifierServiceImpl(weak_factory_.GetWeakPtr(), 39 mojo::MakeStrongBinding(
39 std::move(request)); 40 base::MakeUnique<OverlayPageNotifierServiceImpl>(
41 weak_factory_.GetWeakPtr()),
42 std::move(request));
40 } 43 }
41 44
42 void OverlayJsRenderFrameObserver::SetIsContextualSearchOverlay() { 45 void OverlayJsRenderFrameObserver::SetIsContextualSearchOverlay() {
43 is_contextual_search_overlay_ = true; 46 is_contextual_search_overlay_ = true;
44 } 47 }
45 48
46 void OverlayJsRenderFrameObserver::DidClearWindowObject() { 49 void OverlayJsRenderFrameObserver::DidClearWindowObject() {
47 if (is_contextual_search_overlay_) { 50 if (is_contextual_search_overlay_) {
48 contextual_search::ContextualSearchWrapper::Install(render_frame()); 51 contextual_search::ContextualSearchWrapper::Install(render_frame());
49 } 52 }
(...skipping 13 matching lines...) Expand all
63 ->RemoveInterface<mojom::OverlayPageNotifierService>(); 66 ->RemoveInterface<mojom::OverlayPageNotifierService>();
64 } 67 }
65 } 68 }
66 69
67 void OverlayJsRenderFrameObserver::OnDestruct() { 70 void OverlayJsRenderFrameObserver::OnDestruct() {
68 DestroyOverlayPageNotifierService(); 71 DestroyOverlayPageNotifierService();
69 delete this; 72 delete this;
70 } 73 }
71 74
72 } // namespace contextual_search 75 } // namespace contextual_search
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698