Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: components/contextual_search/browser/contextual_search_js_api_service_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/contextual_search/browser/contextual_search_js_api_service_impl.cc
diff --git a/components/contextual_search/browser/contextual_search_js_api_service_impl.cc b/components/contextual_search/browser/contextual_search_js_api_service_impl.cc
index c664593b1808e003cfab4360af26b74933441be5..12aed8ed2d4cc72f404bfa13b9d3908ad79490e7 100644
--- a/components/contextual_search/browser/contextual_search_js_api_service_impl.cc
+++ b/components/contextual_search/browser/contextual_search_js_api_service_impl.cc
@@ -7,14 +7,13 @@
#include <utility>
#include "components/contextual_search/browser/contextual_search_js_api_handler.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
namespace contextual_search {
ContextualSearchJsApiServiceImpl::ContextualSearchJsApiServiceImpl(
- ContextualSearchJsApiHandler* contextual_search_js_api_handler,
- mojo::InterfaceRequest<mojom::ContextualSearchJsApiService> request)
- : binding_(this, std::move(request)),
- contextual_search_js_api_handler_(contextual_search_js_api_handler) {}
+ ContextualSearchJsApiHandler* contextual_search_js_api_handler)
+ : contextual_search_js_api_handler_(contextual_search_js_api_handler) {}
ContextualSearchJsApiServiceImpl::~ContextualSearchJsApiServiceImpl() {}
@@ -28,9 +27,9 @@ void ContextualSearchJsApiServiceImpl::HandleSetCaption(
void CreateContextualSearchJsApiService(
ContextualSearchJsApiHandler* contextual_search_js_api_handler,
mojo::InterfaceRequest<mojom::ContextualSearchJsApiService> request) {
- // This is strongly bound and owned by the pipe.
- new ContextualSearchJsApiServiceImpl(contextual_search_js_api_handler,
- std::move(request));
+ mojo::MakeStrongBinding(base::MakeUnique<ContextualSearchJsApiServiceImpl>(
+ contextual_search_js_api_handler),
+ std::move(request));
}
} // namespace contextual_search

Powered by Google App Engine
This is Rietveld 408576698