Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: components/contextual_search/browser/contextual_search_js_api_service_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/contextual_search/browser/contextual_search_js_api_service_ impl.h" 5 #include "components/contextual_search/browser/contextual_search_js_api_service_ impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "components/contextual_search/browser/contextual_search_js_api_handler. h" 9 #include "components/contextual_search/browser/contextual_search_js_api_handler. h"
10 #include "mojo/public/cpp/bindings/strong_binding.h"
10 11
11 namespace contextual_search { 12 namespace contextual_search {
12 13
13 ContextualSearchJsApiServiceImpl::ContextualSearchJsApiServiceImpl( 14 ContextualSearchJsApiServiceImpl::ContextualSearchJsApiServiceImpl(
14 ContextualSearchJsApiHandler* contextual_search_js_api_handler, 15 ContextualSearchJsApiHandler* contextual_search_js_api_handler)
15 mojo::InterfaceRequest<mojom::ContextualSearchJsApiService> request) 16 : contextual_search_js_api_handler_(contextual_search_js_api_handler) {}
16 : binding_(this, std::move(request)),
17 contextual_search_js_api_handler_(contextual_search_js_api_handler) {}
18 17
19 ContextualSearchJsApiServiceImpl::~ContextualSearchJsApiServiceImpl() {} 18 ContextualSearchJsApiServiceImpl::~ContextualSearchJsApiServiceImpl() {}
20 19
21 void ContextualSearchJsApiServiceImpl::HandleSetCaption( 20 void ContextualSearchJsApiServiceImpl::HandleSetCaption(
22 const mojo::String& caption, 21 const mojo::String& caption,
23 bool does_answer) { 22 bool does_answer) {
24 contextual_search_js_api_handler_->SetCaption(caption, does_answer); 23 contextual_search_js_api_handler_->SetCaption(caption, does_answer);
25 } 24 }
26 25
27 // static 26 // static
28 void CreateContextualSearchJsApiService( 27 void CreateContextualSearchJsApiService(
29 ContextualSearchJsApiHandler* contextual_search_js_api_handler, 28 ContextualSearchJsApiHandler* contextual_search_js_api_handler,
30 mojo::InterfaceRequest<mojom::ContextualSearchJsApiService> request) { 29 mojo::InterfaceRequest<mojom::ContextualSearchJsApiService> request) {
31 // This is strongly bound and owned by the pipe. 30 mojo::MakeStrongBinding(base::MakeUnique<ContextualSearchJsApiServiceImpl>(
32 new ContextualSearchJsApiServiceImpl(contextual_search_js_api_handler, 31 contextual_search_js_api_handler),
33 std::move(request)); 32 std::move(request));
34 } 33 }
35 34
36 } // namespace contextual_search 35 } // namespace contextual_search
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698