Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2326543003: Add missing linker flags to allow use of custom frameworks on iOS. (Closed)

Created:
4 years, 3 months ago by sdefresne
Modified:
4 years, 3 months ago
Reviewers:
justincohen
CC:
chromium-reviews, mef
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing linker flags to allow use of custom frameworks on iOS. Pass required flags "-rpath @executable/Frameworks" when linking executable to point to the location where the custom frameworks are located in iOS builds. Pass flags "-objc_abi_version 2" to linker flag for execuable and dynamic libraries as is done by Xcode and remove one intermediate config object (unnecessary). BUG=None Committed: https://crrev.com/ba8574b4699241b0240a9a27476c969bc5585334 Cr-Commit-Position: refs/heads/master@{#417403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M build/config/ios/rules.gni View 4 chunks +28 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
sdefresne
Please take a look and send to CQ if lgty. mef: FYI, with this patch, ...
4 years, 3 months ago (2016-09-08 16:31:47 UTC) #4
justincohen
lgtm
4 years, 3 months ago (2016-09-08 16:34:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326543003/1
4 years, 3 months ago (2016-09-08 21:25:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 21:30:20 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 21:33:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba8574b4699241b0240a9a27476c969bc5585334
Cr-Commit-Position: refs/heads/master@{#417403}

Powered by Google App Engine
This is Rietveld 408576698