Use CrNet.framework in crnet_test and crnet_consumer apps.

Use CrNet.framework in crnet_test and crnet_consumer apps.

Committed: https://crrev.com/9c917795c1c89b337f408929947ca057ee04983c
Cr-Commit-Position: refs/heads/master@{#417599}

[mef, 2016-09-08 16:57:22]

mef@chromium.org changed reviewers:
+ sdefresne@chromium.org

[mef, 2016-09-08 16:57:23]

Hi Sylvain, I've confirmed that with your CL both crnet_test and crnet_consumer
run properly on simulator with embedded CrNet.framework.

[sdefresne, 2016-09-08 21:28:22]

lgtm

https://codereview.chromium.org/2323033002/diff/20001/ios/crnet/test/BUILD.gn
File ios/crnet/test/BUILD.gn (right):

https://codereview.chromium.org/2323033002/diff/20001/ios/crnet/test/BUILD.gn...
ios/crnet/test/BUILD.gn:25: "//build/config/sanitizers:deps",
This is not necessary as this dependency is added by the "test" template
already, see line 263 of testing/test.gni.

[mef, 2016-09-09 14:39:30]

Thanks! Could you take a quick look, I've adjusted #import to use CrNet.h from
the framework.

https://codereview.chromium.org/2323033002/diff/20001/ios/crnet/test/BUILD.gn
File ios/crnet/test/BUILD.gn (right):

https://codereview.chromium.org/2323033002/diff/20001/ios/crnet/test/BUILD.gn...
ios/crnet/test/BUILD.gn:25: "//build/config/sanitizers:deps",
On 2016/09/08 21:28:21, sdefresne wrote:
> This is not necessary as this dependency is added by the "test" template
> already, see line 263 of testing/test.gni.

Done.

[sdefresne, 2016-09-09 14:52:42]

lgtm

https://codereview.chromium.org/2323033002/diff/60001/ios/crnet/crnet_consume...
File ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm (right):

https://codereview.chromium.org/2323033002/diff/60001/ios/crnet/crnet_consume...
ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm:8: #include
"base/format_macros.h"
nit: blank line to separate import from framework from include from the project
(as you would do before #import <UIKit/UIKit.h>)

[mef, 2016-09-09 15:01:19]

Thanks! It even passed the ios-simulator-cronet trybot!

https://codereview.chromium.org/2323033002/diff/60001/ios/crnet/crnet_consume...
File ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm (right):

https://codereview.chromium.org/2323033002/diff/60001/ios/crnet/crnet_consume...
ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm:8: #include
"base/format_macros.h"
On 2016/09/09 14:52:42, sdefresne wrote:
> nit: blank line to separate import from framework from include from the
project
> (as you would do before #import <UIKit/UIKit.h>)

Done.

[mef, 2016-09-09 15:01:29]

The CQ bit was checked by mef@chromium.org

[mef, 2016-09-09 15:01:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2323033002/#ps80001
(title: "Address nit.")

[commit-bot: I haz the power, 2016-09-09 15:02:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 16:16:21]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-09 16:17:48]

Description was changed from

==========
Use CrNet.framework in crnet_test and crnet_consumer apps.
==========

to

==========
Use CrNet.framework in crnet_test and crnet_consumer apps.

Committed: https://crrev.com/9c917795c1c89b337f408929947ca057ee04983c
Cr-Commit-Position: refs/heads/master@{#417599}
==========

[commit-bot: I haz the power, 2016-09-09 16:17:49]

Patchset 5 (id:??) landed as
https://crrev.com/9c917795c1c89b337f408929947ca057ee04983c
Cr-Commit-Position: refs/heads/master@{#417599}