Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2316683002: Remove _use_intermediate_source_set variable. (Closed)

Created:
4 years, 3 months ago by sdefresne
Modified:
4 years, 3 months ago
Reviewers:
Olivier
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove _use_intermediate_source_set variable. As the variable is now true (it's end state), it can be removed and the corresponding legacy code. BUG=637065 Committed: https://crrev.com/5475013e3ff37f8882f7bf58911b655ce9ab2f04 Cr-Commit-Position: refs/heads/master@{#417316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -80 lines) Patch
M build/config/ios/rules.gni View 7 chunks +42 lines, -80 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
sdefresne
Please take a look.
4 years, 3 months ago (2016-09-06 15:27:50 UTC) #7
Olivier
lgtm
4 years, 3 months ago (2016-09-06 15:42:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316683002/20001
4 years, 3 months ago (2016-09-08 15:25:06 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-08 16:52:12 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 16:55:34 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5475013e3ff37f8882f7bf58911b655ce9ab2f04
Cr-Commit-Position: refs/heads/master@{#417316}

Powered by Google App Engine
This is Rietveld 408576698