Shrink AOT snapshot size and memory usage.

Shrink AOT snapshot size and memory usage.

 - Conditionally remove fields of Code, Function and ICData that are not used in the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplicate parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery (IsolateSnapshotReader event)
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/47cc06ae66aa6788d795e0d3af6517aaa8f91084

[rmacnak, 2016-09-14 20:25:43]

Description was changed from

==========
Unused fields of RawCode.

BUG=
==========

to

==========
Shrink AOT snapshot size and memory usage.

 - Conditionally remove fields of Code, Function, ICData that are not used in
the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplication parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.
==========

[rmacnak, 2016-09-14 20:28:40]

Description was changed from

==========
Shrink AOT snapshot size and memory usage.

 - Conditionally remove fields of Code, Function, ICData that are not used in
the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplication parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.
==========

to

==========
Shrink AOT snapshot size and memory usage.

 - Conditionally remove fields of Code, Function, ICData that are not used in
the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplication parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)
==========

[rmacnak, 2016-09-14 20:34:46]

Description was changed from

==========
Shrink AOT snapshot size and memory usage.

 - Conditionally remove fields of Code, Function, ICData that are not used in
the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplication parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)
==========

to

==========
Shrink AOT snapshot size and memory usage.

 - Conditionally remove fields of Code, Function and ICData that are not used in
the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplicate parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)
==========

[rmacnak, 2016-09-14 20:36:37]

Description was changed from

==========
Shrink AOT snapshot size and memory usage.

 - Conditionally remove fields of Code, Function and ICData that are not used in
the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplicate parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)
==========

to

==========
Shrink AOT snapshot size and memory usage.

 - Conditionally remove fields of Code, Function and ICData that are not used in
the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplicate parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)
==========

[rmacnak, 2016-09-14 20:36:51]

rmacnak@google.com changed reviewers:
+ asiva@google.com, fschneider@google.com

[Florian Schneider, 2016-09-14 21:32:52]

https://codereview.chromium.org/2326483005/diff/120001/runtime/vm/clustered_s...
File runtime/vm/clustered_snapshot.cc (right):

https://codereview.chromium.org/2326483005/diff/120001/runtime/vm/clustered_s...
runtime/vm/clustered_snapshot.cc:546: #if !defined(DART_PRECOMPILED_RUNTIME)
The reading code will be needed at startup, But would it be possible to exclude
the snapshot writing code completely if DART_PRECOMPILED_RUNTIME is defined?

https://codereview.chromium.org/2326483005/diff/120001/runtime/vm/clustered_s...
runtime/vm/clustered_snapshot.cc:762: data->ptr()->context_scope_ =
ContextScope::null();
Maybe only put handling of context_scope_ with the if-statement, and share the
other parts?

https://codereview.chromium.org/2326483005/diff/120001/runtime/vm/gc_marker.cc
File runtime/vm/gc_marker.cc (right):

https://codereview.chromium.org/2326483005/diff/120001/runtime/vm/gc_marker.c...
runtime/vm/gc_marker.cc:32: void DetachCode() {
Is code collection not disabled when running precompiled code? Maybe you can
just exclude the whole function?

https://codereview.chromium.org/2326483005/diff/120001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2326483005/diff/120001/runtime/vm/object.cc#n...
runtime/vm/object.cc:14855: #if defined(DART_PRECOMPILER)
Can this and the declaration be moved to precompiler.cc / precompiler.h? You
would not need the #ifdef there.

[rmacnak, 2016-09-15 17:01:22]

https://codereview.chromium.org/2326483005/diff/120001/runtime/vm/clustered_s...
File runtime/vm/clustered_snapshot.cc (right):

https://codereview.chromium.org/2326483005/diff/120001/runtime/vm/clustered_s...
runtime/vm/clustered_snapshot.cc:546: #if !defined(DART_PRECOMPILED_RUNTIME)
On 2016/09/14 21:32:52, Florian Schneider wrote:
> The reading code will be needed at startup, But would it be possible to
exclude
> the snapshot writing code completely if DART_PRECOMPILED_RUNTIME is defined?
> 

Done.

https://codereview.chromium.org/2326483005/diff/120001/runtime/vm/clustered_s...
runtime/vm/clustered_snapshot.cc:762: data->ptr()->context_scope_ =
ContextScope::null();
On 2016/09/14 21:32:52, Florian Schneider wrote:
> Maybe only put handling of context_scope_ with the if-statement, and share the
> other parts?

Done.

https://codereview.chromium.org/2326483005/diff/120001/runtime/vm/gc_marker.cc
File runtime/vm/gc_marker.cc (right):

https://codereview.chromium.org/2326483005/diff/120001/runtime/vm/gc_marker.c...
runtime/vm/gc_marker.cc:32: void DetachCode() {
On 2016/09/14 21:32:52, Florian Schneider wrote:
> Is code collection not disabled when running precompiled code? Maybe you can
> just exclude the whole function?

Code collection is always off for AOT. Done.

[Florian Schneider, 2016-09-15 17:17:37]

LGTM

https://codereview.chromium.org/2326483005/diff/140001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/2326483005/diff/140001/runtime/vm/object.h#ne...
runtime/vm/object.h:4903: #if defined(DART_PRECOMPILED_RUNTIME)
Is this used in AOT? UNREACHABLE as well?

https://codereview.chromium.org/2326483005/diff/140001/runtime/vm/raw_object_...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/2326483005/diff/140001/runtime/vm/raw_object_...
runtime/vm/raw_object_snapshot.cc:767: #if !defined(DART_PRECOMPILED_RUNTIME)
In a separate CL, it may be worth excluding the writer code not used for
messages in precompiled runtime like you did for the clustered writer.

[rmacnak, 2016-09-15 21:03:51]

Description was changed from

==========
Shrink AOT snapshot size and memory usage.

 - Conditionally remove fields of Code, Function and ICData that are not used in
the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplicate parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)
==========

to

==========
Shrink AOT snapshot size and memory usage.

 - Conditionally remove fields of Code, Function and ICData that are not used in
the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplicate parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery (IsolateSnapshotReader event)
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)
==========

[rmacnak, 2016-09-15 22:06:47]

Description was changed from

==========
Shrink AOT snapshot size and memory usage.

 - Conditionally remove fields of Code, Function and ICData that are not used in
the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplicate parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery (IsolateSnapshotReader event)
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)
==========

to

==========
Shrink AOT snapshot size and memory usage.

 - Conditionally remove fields of Code, Function and ICData that are not used in
the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplicate parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery (IsolateSnapshotReader event)
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/47cc06ae66aa6788d795e0d3af6517aaa8f91084
==========

[rmacnak, 2016-09-15 22:06:48]

Committed patchset #8 (id:140001) manually as
47cc06ae66aa6788d795e0d3af6517aaa8f91084 (presubmit successful).

[rmacnak, 2016-09-16 21:59:02]

https://chromiumcodereview.appspot.com/2326483005/diff/140001/runtime/vm/obje...
File runtime/vm/object.h (right):

https://chromiumcodereview.appspot.com/2326483005/diff/140001/runtime/vm/obje...
runtime/vm/object.h:4903: #if defined(DART_PRECOMPILED_RUNTIME)
On 2016/09/15 17:17:37, Florian Schneider wrote:
> Is this used in AOT? UNREACHABLE as well?

From the profiler.

https://chromiumcodereview.appspot.com/2326483005/diff/140001/runtime/vm/raw_...
File runtime/vm/raw_object_snapshot.cc (right):

https://chromiumcodereview.appspot.com/2326483005/diff/140001/runtime/vm/raw_...
runtime/vm/raw_object_snapshot.cc:767: #if !defined(DART_PRECOMPILED_RUNTIME)
On 2016/09/15 17:17:37, Florian Schneider wrote:
> In a separate CL, it may be worth excluding the writer code not used for
> messages in precompiled runtime like you did for the clustered writer.
> 

Acknowledged.