Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: runtime/observatory/lib/src/elements/script_inset.dart

Issue 2326483005: Shrink AOT snapshot size and memory usage. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/script_inset.dart
diff --git a/runtime/observatory/lib/src/elements/script_inset.dart b/runtime/observatory/lib/src/elements/script_inset.dart
index a4beb8939dffa50973141f6add6015a9db802dcc..877a6efbb4bc61b77c1398132e09bc51edb3158f 100644
--- a/runtime/observatory/lib/src/elements/script_inset.dart
+++ b/runtime/observatory/lib/src/elements/script_inset.dart
@@ -72,6 +72,8 @@ class ScriptInsetElement extends HtmlElement implements Renderable {
ScriptInsetElement.created() : super.created();
+ bool get noSource => _startPos == -1;
+
@override
void attached() {
super.attached();
@@ -109,7 +111,9 @@ class ScriptInsetElement extends HtmlElement implements Renderable {
}
void render() {
- if (_loadedScript == null) {
+ if (noSource) {
+ children = [new SpanElement()..text = 'No source'];
+ } else if (_loadedScript == null) {
children = [new SpanElement()..text = 'Loading...'];
} else {
final table = linesTable();
@@ -204,6 +208,8 @@ class ScriptInsetElement extends HtmlElement implements Renderable {
// Build _rangeMap and _callSites from a source report.
Future _refreshSourceReport() async {
+ if (noSource) return;
+
var reports = [S.Isolate.kCallSitesReport,
S.Isolate.kPossibleBreakpointsReport];
if (_includeProfile) {

Powered by Google App Engine
This is Rietveld 408576698