Shrink AOT snapshot size and memory usage.

runtime/vm/gc_marker.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/gc_marker.h"
 
 #include "vm/allocation.h"
 #include "vm/dart_api_state.h"
 #include "vm/isolate.h"
 #include "vm/log.h"
@@ skipping 11 matching lines @@
 namespace dart {
 
 class SkippedCodeFunctions : public ZoneAllocated {
  public:
   SkippedCodeFunctions() {}
 
   void Add(RawFunction* func) {
     skipped_code_functions_.Add(func);
   }
 
   void DetachCode() {

[Florian Schneider, 2016/09/14 21:32:52]

Is code collection not disabled when running precompiled code? Maybe you can
just exclude the whole function?

[rmacnak, 2016/09/15 17:01:22]

Code collection is always off for AOT. Done.

     intptr_t unoptimized_code_count = 0;
     intptr_t current_code_count = 0;
     for (int i = 0; i < skipped_code_functions_.length(); i++) {
       RawFunction* func = skipped_code_functions_[i];
       RawCode* code = func->ptr()->code_;
       if (!code->IsMarked()) {
         // If the code wasn't strongly visited through other references
         // after skipping the function's code pointer, then we disconnect the
         // code from the function.
         func->StorePointer(
             &(func->ptr()->code_),
             StubCode::LazyCompile_entry()->code());
         uword entry_point = StubCode::LazyCompile_entry()->EntryPoint();
         func->ptr()->entry_point_ = entry_point;
         if (FLAG_log_code_drop) {
           // NOTE: This code runs while GC is in progress and runs within
           // a NoHandleScope block. Hence it is not okay to use a regular Zone
           // or Scope handle. We use a direct stack handle so the raw pointer in
           // this handle is not traversed. The use of a handle is mainly to
           // be able to reuse the handle based code and avoid having to add
           // helper functions to the raw object interface.
           String name;
           name = func->ptr()->name_;
           THR_Print("Detaching code: %s\n", name.ToCString());
           current_code_count++;
         }
       }
 
+#if defined(DART_PRECOMPILED_RUNTIME)
+      UNREACHABLE();
+#else
       code = func->ptr()->unoptimized_code_;
       if (!code->IsMarked()) {
         // If the code wasn't strongly visited through other references
         // after skipping the function's code pointer, then we disconnect the
         // code from the function.
         func->StorePointer(&(func->ptr()->unoptimized_code_), Code::null());
         if (FLAG_log_code_drop) {
           unoptimized_code_count++;
         }
       }
+#endif
     }
     if (FLAG_log_code_drop) {
       THR_Print("  total detached current: %" Pd "\n", current_code_count);
       THR_Print("  total detached unoptimized: %" Pd "\n",
                 unoptimized_code_count);
     }
     // Clean up.
     skipped_code_functions_.Clear();
   }
 
@@ skipping 710 matching lines @@
       // Phase 3: Finalize results from all markers (detach code, etc.).
       barrier.Exit();
     }
     ProcessWeakTables(page_space);
     ProcessObjectIdTable(isolate);
   }
   Epilogue(isolate, invoke_api_callbacks);
 }
 
 }  // namespace dart