Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2326073002: Refactor QuicCryptoServerStream. (Closed)

Created:
4 years, 3 months ago by ianswett
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, vlovich_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor QuicCryptoServerStream. Rather than tying the crypto server stream to SPDY, provide an interface for implementing the load-balancing it's trying to perform so that other (e.g. P2P) clients can utilize it without adopting SPDY in any way. Non-functional refactor to remove dependance on QuicSpdySession from QuicCryptoServerStream. Merge internal change: 132003062 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -129 lines) Patch
M net/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 3 chunks +27 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M net/quic/core/quic_server_session_base.h View 4 chunks +8 lines, -29 lines 0 comments Download
M net/quic/core/quic_server_session_base.cc View 2 chunks +1 line, -13 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 6 chunks +12 lines, -8 lines 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.h View 5 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 7 chunks +16 lines, -8 lines 0 comments Download
M net/tools/quic/quic_server.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M net/tools/quic/quic_simple_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session_helper_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 6 chunks +17 lines, -12 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/mock_quic_server_session_visitor.h View 3 chunks +5 lines, -4 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_server_session_visitor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_server.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_server.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
ianswett
4 years, 3 months ago (2016-09-09 16:02:57 UTC) #1
Ryan Hamilton
4 years, 3 months ago (2016-09-09 17:19:52 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698