Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: net/quic/core/quic_server_session_base_test.cc

Issue 2326073002: Refactor QuicCryptoServerStream. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_server_session_base.cc ('k') | net/quic/test_tools/mock_quic_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_server_session_base_test.cc
diff --git a/net/quic/core/quic_server_session_base_test.cc b/net/quic/core/quic_server_session_base_test.cc
index 24a8889c100fe77c0386c26ea852be8c42bef076..9811b6317d51f53d43a4ef6be5659a92fd65e76f 100644
--- a/net/quic/core/quic_server_session_base_test.cc
+++ b/net/quic/core/quic_server_session_base_test.cc
@@ -75,7 +75,7 @@ class TestServerSession : public QuicServerSessionBase {
TestServerSession(const QuicConfig& config,
QuicConnection* connection,
QuicServerSessionBase::Visitor* visitor,
- QuicServerSessionBase::Helper* helper,
+ QuicCryptoServerStream::Helper* helper,
const QuicCryptoServerConfig* crypto_config,
QuicCompressedCertsCache* compressed_certs_cache)
: QuicServerSessionBase(config,
@@ -114,7 +114,8 @@ class TestServerSession : public QuicServerSessionBase {
QuicCompressedCertsCache* compressed_certs_cache) override {
return new QuicCryptoServerStream(
crypto_config, compressed_certs_cache,
- FLAGS_enable_quic_stateless_reject_support, this);
+ FLAGS_enable_quic_stateless_reject_support, this,
+ stream_helper());
}
};
@@ -141,7 +142,7 @@ class QuicServerSessionBaseTest : public ::testing::TestWithParam<QuicVersion> {
&helper_, &alarm_factory_, Perspective::IS_SERVER,
SupportedVersions(GetParam()));
session_.reset(new TestServerSession(config_, connection_, &owner_,
- &session_helper_, &crypto_config_,
+ &stream_helper_, &crypto_config_,
&compressed_certs_cache_));
MockClock clock;
handshake_message_.reset(crypto_config_.AddDefaultConfig(
@@ -152,7 +153,7 @@ class QuicServerSessionBaseTest : public ::testing::TestWithParam<QuicVersion> {
}
StrictMock<MockQuicServerSessionVisitor> owner_;
- StrictMock<MockQuicServerSessionHelper> session_helper_;
+ StrictMock<MockQuicCryptoServerStreamHelper> stream_helper_;
MockQuicConnectionHelper helper_;
MockAlarmFactory alarm_factory_;
StrictMock<MockQuicConnection>* connection_;
@@ -371,11 +372,13 @@ class MockQuicCryptoServerStream : public QuicCryptoServerStream {
explicit MockQuicCryptoServerStream(
const QuicCryptoServerConfig* crypto_config,
QuicCompressedCertsCache* compressed_certs_cache,
- QuicServerSessionBase* session)
+ QuicServerSessionBase* session,
+ QuicCryptoServerStream::Helper* helper)
: QuicCryptoServerStream(crypto_config,
compressed_certs_cache,
FLAGS_enable_quic_stateless_reject_support,
- session) {}
+ session,
+ helper) {}
~MockQuicCryptoServerStream() override {}
MOCK_METHOD1(SendServerConfigUpdate,
@@ -411,8 +414,9 @@ TEST_P(QuicServerSessionBaseTest, BandwidthEstimates) {
const string serving_region = "not a real region";
session_->set_serving_region(serving_region);
- MockQuicCryptoServerStream* crypto_stream = new MockQuicCryptoServerStream(
- &crypto_config_, &compressed_certs_cache_, session_.get());
+ MockQuicCryptoServerStream* crypto_stream =
+ new MockQuicCryptoServerStream(&crypto_config_, &compressed_certs_cache_,
+ session_.get(), &stream_helper_);
QuicServerSessionBasePeer::SetCryptoStream(session_.get(), crypto_stream);
// Set some initial bandwidth values.
« no previous file with comments | « net/quic/core/quic_server_session_base.cc ('k') | net/quic/test_tools/mock_quic_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698