Issue 2319933003: Move StatelessRejector to a heap-allocated model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2319933003: Move StatelessRejector to a heap-allocated model (Closed)

Created:
4 years, 3 months ago by ianswett

Modified:
4 years, 3 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, gredner

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move StatelessRejector to a heap-allocated model Note that this CL does not actually change any functionality, and several pieces necessary for supporting a fully async ValidateClientHello are missing. Those will come in a follow-up CL - this change aims simply to change the shape of the code so that later changes will be easier to understand. Merge internal change: 131961330 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+215 lines, -85 lines)			Patch
M	net/tools/quic/quic_dispatcher.h	View	4 chunks	+14 lines, -5 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.cc	View	5 chunks	+85 lines, -30 lines	0 comments	Download
M	net/tools/quic/stateless_rejector.h	View	5 chunks	+21 lines, -4 lines	0 comments	Download
M	net/tools/quic/stateless_rejector.cc	View	7 chunks	+37 lines, -19 lines	0 comments	Download
M	net/tools/quic/stateless_rejector_test.cc	View	7 chunks	+58 lines, -27 lines	0 comments	Download

Depends on Patchset:

Issue 2325803002 Patch 1

Dependent Patchsets:

Issue 2326073002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages