Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2325933002: Move m_caretVisibility from CaretBase to FrameCaret (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move m_caretVisibility from CaretBase to FrameCaret This patch moves |m_caretVisibility| from |CaretBase| class to |FrameCaret| since |m_caretVisibility| is used only in |FramreCaret| class for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/1c337f78d336b46b6ce2e251b09c75291130f9f9 Cr-Commit-Position: refs/heads/master@{#417521}

Patch Set 1 : 2016-09-09T14:05:22 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -29 lines) Patch
M third_party/WebKit/Source/core/editing/CaretBase.h View 3 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 3 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DragCaretController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.h View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.cpp View 7 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-09-09 05:52:29 UTC) #5
yoichio
lgtm
4 years, 3 months ago (2016-09-09 06:34:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325933002/1
4 years, 3 months ago (2016-09-09 06:35:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 06:39:17 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 06:42:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c337f78d336b46b6ce2e251b09c75291130f9f9
Cr-Commit-Position: refs/heads/master@{#417521}

Powered by Google App Engine
This is Rietveld 408576698