Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/core/editing/CaretBase.h

Issue 2325933002: Move m_caretVisibility from CaretBase to FrameCaret (Closed)
Patch Set: 2016-09-09T14:05:22 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/CaretBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/CaretBase.h
diff --git a/third_party/WebKit/Source/core/editing/CaretBase.h b/third_party/WebKit/Source/core/editing/CaretBase.h
index a4431ab4e97b1a518fd4c32450f5e20d6b5f4803..f30399968288db63f6192e4e60cd588e0c7bf189 100644
--- a/third_party/WebKit/Source/core/editing/CaretBase.h
+++ b/third_party/WebKit/Source/core/editing/CaretBase.h
@@ -42,12 +42,10 @@ class GraphicsContext;
class LayoutBlock;
class LayoutViewItem;
-enum class CaretVisibility { Visible, Hidden };
-
class CORE_EXPORT CaretBase : public GarbageCollectedFinalized<CaretBase>, public DisplayItemClient {
WTF_MAKE_NONCOPYABLE(CaretBase);
public:
- explicit CaretBase(CaretVisibility = CaretVisibility::Hidden);
+ CaretBase();
virtual ~CaretBase();
void invalidateCaretRect(Node*);
@@ -64,10 +62,6 @@ public:
const LayoutRect& localCaretRectWithoutUpdate() const { return m_caretLocalRect; }
- virtual void setCaretVisibility(CaretVisibility);
- bool caretIsVisible() const { return m_caretVisibility == CaretVisibility::Visible; }
- CaretVisibility getCaretVisibility() const { return m_caretVisibility; }
-
static LayoutBlock* caretLayoutObject(Node*);
void invalidateLocalCaretRect(Node*, const LayoutRect&);
@@ -79,7 +73,6 @@ public:
private:
LayoutRect m_caretLocalRect; // caret rect in coords local to the layoutObject responsible for painting the caret
- CaretVisibility m_caretVisibility;
LayoutRect m_visualRect;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/CaretBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698