Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: third_party/WebKit/Source/core/editing/FrameCaret.h

Issue 2325933002: Move m_caretVisibility from CaretBase to FrameCaret (Closed)
Patch Set: 2016-09-09T14:05:22 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameCaret.h
diff --git a/third_party/WebKit/Source/core/editing/FrameCaret.h b/third_party/WebKit/Source/core/editing/FrameCaret.h
index 37f1203ed8c04f344b37f20aef1a122748c94034..1f6eb30df5c9d2d8d26adedbefe63ce9f2ed128d 100644
--- a/third_party/WebKit/Source/core/editing/FrameCaret.h
+++ b/third_party/WebKit/Source/core/editing/FrameCaret.h
@@ -34,6 +34,8 @@ namespace blink {
class SelectionEditor;
+enum class CaretVisibility { Visible, Hidden };
+
class CORE_EXPORT FrameCaret final : public CaretBase {
public:
FrameCaret(LocalFrame*, const SelectionEditor&);
@@ -49,7 +51,7 @@ public:
void stopCaretBlinkTimer();
void startBlinkCaret();
- void setCaretVisibility(CaretVisibility) override;
+ void setCaretVisibility(CaretVisibility);
bool isCaretBoundsDirty() const { return m_caretRectDirty; }
void setCaretRectNeedsUpdate();
// If |forceInvalidation| is true the caret's previous and new rectangles
@@ -88,6 +90,7 @@ private:
// caret when it moves.
Member<Node> m_previousCaretNode;
LayoutRect m_previousCaretRect;
+ CaretVisibility m_caretVisibility;
CaretVisibility m_previousCaretVisibility;
Timer<FrameCaret> m_caretBlinkTimer;
bool m_caretRectDirty : 1;
« no previous file with comments | « third_party/WebKit/Source/core/editing/DragCaretController.cpp ('k') | third_party/WebKit/Source/core/editing/FrameCaret.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698