Adds a 'Done' button at the end of hats survey

Adds a 'Done' button at the end of hats survey

BUG=611781
COMPONENT=Hats, Chrome OS, Resources
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c6da1357320786a8fdd17680e74ae34804c73f05
Cr-Commit-Position: refs/heads/master@{#417985}

[malaykeshav, 2016-09-09 00:07:40]

Description was changed from

==========
Adds a 'Done' button at the end of hats survey

BUG=611781
COMPONENT=Hats, Chrome OS, Resources
==========

to

==========
Adds a 'Done' button at the end of hats survey

BUG=611781
COMPONENT=Hats, Chrome OS, Resources
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[malaykeshav, 2016-09-09 00:08:04]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 00:08:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2016-09-09 00:08:42]

malaykeshav@chromium.org changed reviewers:
+ xiyuan@chromium.org

[malaykeshav, 2016-09-09 00:08:43]

PTAL.
Adds a 'Done' button at the end of the survey.

[commit-bot: I haz the power, 2016-09-09 00:12:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:12:35]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2016-09-09 17:06:22]

https://codereview.chromium.org/2325883002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/hats/hats.html (right):

https://codereview.chromium.org/2325883002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/hats/hats.html:11: right: 25px;
Do we need to worry about RTL?

https://codereview.chromium.org/2325883002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/hats/hats.html:41: <a href="javascript:done()"
role="button">
Typically, we do something like this instead of inline js calls:

<a id="link-button" href="#">...</a>

then in JS:
document.addEventListener('DOMContentLoaded', function() {
  var linkButton = document.getElementById('link-button');
  linkButton.onclick = done;  // Or get rid of 'done' and put body here
});

https://codereview.chromium.org/2325883002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/hats/hats.html:42: <div id="id-done-button"
class="done-button">Done</div>
We should use a placeholder similar to what we did for $SCRIPT_SRC for "Done"
and put the string in grd file.

[malaykeshav, 2016-09-09 17:06:54]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 17:07:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2016-09-09 18:00:32]

https://codereview.chromium.org/2325883002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/hats/hats.html (right):

https://codereview.chromium.org/2325883002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/hats/hats.html:11: right: 25px;
On 2016/09/09 at 17:06:22, xiyuan wrote:
> Do we need to worry about RTL?

As of now the survey is only in English.

https://codereview.chromium.org/2325883002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/hats/hats.html:41: <a href="javascript:done()"
role="button">
On 2016/09/09 at 17:06:22, xiyuan wrote:
> Typically, we do something like this instead of inline js calls:
> 
> <a id="link-button" href="#">...</a>
> 
> then in JS:
> document.addEventListener('DOMContentLoaded', function() {
>   var linkButton = document.getElementById('link-button');
>   linkButton.onclick = done;  // Or get rid of 'done' and put body here
> });

Done

https://codereview.chromium.org/2325883002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/hats/hats.html:42: <div id="id-done-button"
class="done-button">Done</div>
On 2016/09/09 at 17:06:22, xiyuan wrote:
> We should use a placeholder similar to what we did for $SCRIPT_SRC for "Done"
and put the string in grd file.

Done

[malaykeshav, 2016-09-09 18:00:36]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 18:01:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-09-09 18:04:27]

lgtm

[commit-bot: I haz the power, 2016-09-09 19:05:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 19:05:10]

Dry run: This issue passed the CQ dry run.

[malaykeshav, 2016-09-09 20:31:27]

The CQ bit was checked by malaykeshav@chromium.org

[commit-bot: I haz the power, 2016-09-09 20:32:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2016-09-09 20:42:21]

The CQ bit was unchecked by malaykeshav@chromium.org

[malaykeshav, 2016-09-09 20:42:59]

The CQ bit was checked by malaykeshav@chromium.org

[malaykeshav, 2016-09-09 20:42:59]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2325883002/#ps40001
(title: "Adds a 'Done' button at the end of hats survey")

[commit-bot: I haz the power, 2016-09-09 20:43:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 21:07:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 21:07:52]

Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[malaykeshav, 2016-09-09 21:21:39]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 21:22:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2016-09-09 21:27:17]

Patchset #4 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-09-09 21:29:30]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[commit-bot: I haz the power, 2016-09-09 21:39:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 21:39:36]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[malaykeshav, 2016-09-12 17:24:00]

The CQ bit was checked by malaykeshav@chromium.org

[malaykeshav, 2016-09-12 17:24:00]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2325883002/#ps40001
(title: "Adds a 'Done' button at the end of hats survey")

[commit-bot: I haz the power, 2016-09-12 17:24:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 18:47:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-12 18:48:49]

Description was changed from

==========
Adds a 'Done' button at the end of hats survey

BUG=611781
COMPONENT=Hats, Chrome OS, Resources
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Adds a 'Done' button at the end of hats survey

BUG=611781
COMPONENT=Hats, Chrome OS, Resources
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c6da1357320786a8fdd17680e74ae34804c73f05
Cr-Commit-Position: refs/heads/master@{#417985}
==========

[commit-bot: I haz the power, 2016-09-12 18:48:50]

Patchset 3 (id:??) landed as
https://crrev.com/c6da1357320786a8fdd17680e74ae34804c73f05
Cr-Commit-Position: refs/heads/master@{#417985}