Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: chrome/browser/chromeos/hats/hats_dialog.cc

Issue 2325883002: Adds a 'Done' button at the end of hats survey (Closed)
Patch Set: Adds a 'Done' button at the end of hats survey Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chrome/browser/resources/chromeos/hats/hats.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/hats/hats_dialog.cc
diff --git a/chrome/browser/chromeos/hats/hats_dialog.cc b/chrome/browser/chromeos/hats/hats_dialog.cc
index bdcb42fef36aa0018b4dcac61d5a4e4821375ac9..618ece27255f254e7f1a2f1757a7e619a1bd3aab 100644
--- a/chrome/browser/chromeos/hats/hats_dialog.cc
+++ b/chrome/browser/chromeos/hats/hats_dialog.cc
@@ -10,10 +10,12 @@
#include "chrome/browser/ui/browser_dialogs.h"
#include "chrome/common/pref_names.h"
#include "chrome/grit/browser_resources.h"
+#include "chrome/grit/generated_resources.h"
#include "chromeos/system/version_loader.h"
#include "components/prefs/pref_service.h"
#include "components/version_info/version_info.h"
#include "content/public/browser/browser_thread.h"
+#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/geometry/size.h"
@@ -31,7 +33,8 @@ const int kDefaultHeight = 420;
constexpr char kSiteID[] = "cs5lsagwwbho7l5cbbdniso22e";
constexpr char kGooglerSiteID[] = "z56p2hjy7pegxh3gmmur4qlwha";
-constexpr char kReplacementToken[] = "$SCRIPT_SRC";
+constexpr char kScriptSrcReplacementToken[] = "$SCRIPT_SRC";
+constexpr char kDoneButtonLabelReplacementToken[] = "$DONE_BUTTON_LABEL";
// Base URL to fetch the google consumer survey script.
constexpr char kBaseFormatUrl[] =
"https://www.google.com/insights/consumersurveys/"
@@ -55,10 +58,15 @@ std::string LoadLocalHtmlAsString(std::string site_id,
ResourceBundle::GetSharedInstance()
.GetRawDataResource(IDR_HATS_HTML)
.CopyToString(&html_data);
- size_t pos = html_data.find(kReplacementToken);
- html_data.replace(pos, strlen(kReplacementToken),
+
+ size_t pos = html_data.find(kScriptSrcReplacementToken);
+ html_data.replace(pos, strlen(kScriptSrcReplacementToken),
base::StringPrintf(kBaseFormatUrl, site_id.c_str(),
site_context.c_str()));
+
+ pos = html_data.find(kDoneButtonLabelReplacementToken);
+ html_data.replace(pos, strlen(kDoneButtonLabelReplacementToken),
+ l10n_util::GetStringUTF8(IDS_HATS_DONE_BUTTON_LABEL));
return html_data;
}
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chrome/browser/resources/chromeos/hats/hats.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698