chrome/browser/resources/chromeos/hats/hats.html - Issue 2325883002: Adds a 'Done' button at the end of hats survey

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/hats/hats.html

Issue 2325883002: Adds a 'Done' button at the end of hats survey (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

	3 <style>

	4 .done-button {

	5 bottom: 17px;

	6 color: rgb(33, 150, 243);

	7 display: none;

	8 filter: none;

	9 font: 400 16px Roboto,RobotoDraft,Helvetica,sans-serif;

	10 position: fixed;

	11 right: 25px;
	xiyuan 2016/09/09 17:06:22 Do we need to worry about RTL? Do we need to worry about RTL? malaykeshav 2016/09/09 18:00:32 As of now the survey is only in English. Show quoted text On 2016/09/09 at 17:06:22, xiyuan wrote: > Do we need to worry about RTL? As of now the survey is only in English.
	12 text-shadow: none;

	13 text-transform: uppercase;

	14 z-index: 10;

	15 }

	16 </style>

3 <script>	17 <script>

4 /**	18 /**

5 * Handles the callback when the survey is submitted or when the survey	19 * Handles the callback when the survey is submitted or when the survey

6 * has already been submitted in the past.	20 * has already been submitted in the past.

7 * @param {boolean} isFirstRun Will be true when the user just earned	21 * @param {boolean} isFirstRun Will be true when the user just earned

8 * access to the content and false if the user had already had access	22 * access to the content and false if the user had already had access

9 * previously.	23 * previously.

10 */	24 */

11 var didFinishSurvey = function(isFirstRun) {	25 var didFinishSurvey = function(isFirstRun) {

12 if (!isFirstRun) {	26 if (!isFirstRun) {

13 return;	27 return;

14 }	28 }

15 /* Resize the window to match the size of thank you message. */	29

16 window.resizeTo(400, 110);	30 /* Display the done button at the end of the survey. */

	31 document.getElementById('id-done-button').style.display = 'block';

	32 };

	33

	34 var done = function() {

	35 window.close();

17 };	36 };

18 </script>	37 </script>

19 <script src="$SCRIPT_SRC"></script>	38 <script src="$SCRIPT_SRC"></script>

20 </head>	39 </head>

	40 <body>

	41 <a href="javascript:done()" role="button">
	xiyuan 2016/09/09 17:06:22 Typically, we do something like this instead of in Typically, we do something like this instead of inline js calls: <a id="link-button" href="#">...</a> then in JS: document.addEventListener('DOMContentLoaded', function() { var linkButton = document.getElementById('link-button'); linkButton.onclick = done; // Or get rid of 'done' and put body here }); malaykeshav 2016/09/09 18:00:32 Done Show quoted text On 2016/09/09 at 17:06:22, xiyuan wrote: > Typically, we do something like this instead of inline js calls: > > <a id="link-button" href="#">...</a> > > then in JS: > document.addEventListener('DOMContentLoaded', function() { > var linkButton = document.getElementById('link-button'); > linkButton.onclick = done; // Or get rid of 'done' and put body here > }); Done
	42 <div id="id-done-button" class="done-button">Done</div>
	xiyuan 2016/09/09 17:06:22 We should use a placeholder similar to what we did We should use a placeholder similar to what we did for $SCRIPT_SRC for "Done" and put the string in grd file. malaykeshav 2016/09/09 18:00:32 Done Show quoted text On 2016/09/09 at 17:06:22, xiyuan wrote: > We should use a placeholder similar to what we did for $SCRIPT_SRC for "Done" and put the string in grd file. Done
	43 </a>

	44 </body>

21 </html>	45 </html>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »