Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2325583002: Revert of [Bindings] Remove aggregation of generated binding code (Closed)

Created:
4 years, 3 months ago by peria
Modified:
4 years, 3 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Bindings] Remove aggregation of generated binding code (patchset #3 id:60001 of https://codereview.chromium.org/2318933002/ ) Reason for revert: Build break http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10652 Original issue's description: > Remove aggregation of generated binding code. > > After this change, we maybe able to skip needless compiles > based on redundant dependencies. (issue 388172) > Plus, it is expected to compile those files in parallel. > > BUG=634231, 388172 > > Committed: https://crrev.com/134a59bd48149d721ce06554570db1b2b5bdee55 > Cr-Commit-Position: refs/heads/master@{#417216} TBR=bashi@chromium.org,yukishiino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634231, 388172 Committed: https://crrev.com/0f82e43808017ab95d877be86eb63fe1e4057e97 Cr-Commit-Position: refs/heads/master@{#417226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -68 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/BUILD.gn View 3 chunks +101 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/BUILD.gn View 4 chunks +26 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/generated.gni View 2 chunks +91 lines, -18 lines 0 comments Download
A third_party/WebKit/Source/bindings/scripts/aggregate_generated_bindings.py View 1 chunk +188 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py View 2 chunks +3 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/scripts.gni View 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
peria
Created Revert of [Bindings] Remove aggregation of generated binding code
4 years, 3 months ago (2016-09-08 08:30:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325583002/1
4 years, 3 months ago (2016-09-08 08:30:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 08:32:39 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d7586a77bd18573597cc48bbd2e0e6fb0fbc0fb9 Cr-Commit-Position: refs/heads/master@{#417225}
4 years, 3 months ago (2016-09-08 08:33:54 UTC) #7
Yuki
lgtm
4 years, 3 months ago (2016-09-08 08:35:53 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0f82e43808017ab95d877be86eb63fe1e4057e97 Cr-Commit-Position: refs/heads/master@{#417226}
4 years, 3 months ago (2016-09-08 08:36:32 UTC) #10
haraken
LGTM
4 years, 3 months ago (2016-09-08 08:51:55 UTC) #11
peria
4 years, 3 months ago (2016-09-09 02:21:25 UTC) #12
Message was sent while issue was closed.
Note:
This CL was committed twice due to a CQ issue http://crbug.com/432905
and the second commit was applied only on scripts.gni.

Powered by Google App Engine
This is Rietveld 408576698