Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Side by Side Diff: third_party/WebKit/Source/bindings/modules/v8/BUILD.gn

Issue 2325583002: Revert of [Bindings] Remove aggregation of generated binding code (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/WebKit/Source/bindings/modules/v8/generated.gni") 5 import("//third_party/WebKit/Source/bindings/modules/v8/generated.gni")
6 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni") 6 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
7 import("//third_party/WebKit/Source/modules/modules.gni") 7 import("//third_party/WebKit/Source/modules/modules.gni")
8 import("//third_party/WebKit/Source/modules/modules_idl_files.gni") 8 import("//third_party/WebKit/Source/modules/modules_idl_files.gni")
9 9
10 visibility = [ "//third_party/WebKit/*" ] 10 visibility = [ "//third_party/WebKit/*" ]
11 11
12 # bindings_modules_generated in modules/v8/generated.gyp 12 # bindings_modules_generated in modules/v8/generated.gyp
13 group("bindings_modules_generated") { 13 group("bindings_modules_generated") {
14 public_deps = [ 14 public_deps = [
15 ":bindings_modules_impl_generated", 15 ":bindings_modules_impl_generated",
16 ":bindings_modules_v8_generated_aggregate",
17 ":bindings_modules_v8_generated_individual",
16 ":bindings_modules_v8_generated_init_partial", 18 ":bindings_modules_v8_generated_init_partial",
17 ":generate_bindings_modules_v8_interfaces", 19 ":bindings_modules_v8_generated_partial_aggregate",
18 ":generate_bindings_modules_v8_partial_interfaces", 20 ":bindings_modules_v8_generated_partial_individual",
19 ] 21 ]
20 } 22 }
21 23
22 idl_compiler("generate_bindings_modules_v8_interfaces") { 24 # bindings_modules_generated_aggregate in modules/v8/generated.gyp
25 aggregate_generated_bindings("bindings_modules_v8_generated_aggregate") {
26 sources = modules_definition_idl_files
27 component_dir = "modules"
28 is_partial = false
29 outputs = bindings_modules_generated_aggregate_files
30 }
31
32 # bindings_modules_generated_individual in modules/v8/generated.gyp
33 idl_compiler("bindings_modules_v8_generated_individual") {
23 # Note in GYP this is modules_interface_idl_files but this variable is just 34 # Note in GYP this is modules_interface_idl_files but this variable is just
24 # defined to modules_definition_idl_files. 35 # defined to modules_definition_idl_files.
25 sources = modules_definition_idl_files 36 sources = modules_definition_idl_files
26 output_dir = bindings_modules_v8_output_dir 37 output_dir = bindings_modules_v8_output_dir
27 output_name_suffix = "" 38 output_name_suffix = ""
28 target_component = "modules" 39 target_component = "modules"
29 } 40 }
30 41
42 # bindings_modules_impl_generated in modules/v8/generated.gyp
31 idl_impl("bindings_modules_impl_generated") { 43 idl_impl("bindings_modules_impl_generated") {
32 sources = modules_dictionary_idl_files 44 sources = modules_dictionary_idl_files
33 outputs = bindings_modules_generated_union_type_files + 45 outputs = bindings_modules_generated_union_type_files +
34 generated_modules_dictionary_files 46 generated_modules_dictionary_files
35 output_dir = bindings_modules_v8_output_dir 47 output_dir = bindings_modules_v8_output_dir
36 target_component = "modules" 48 target_component = "modules"
37 } 49 }
38 50
39 idl_compiler("generate_bindings_modules_v8_partial_interfaces") { 51 # bindings_modules_generated_individual in modules/v8/generated.gyp
52 idl_compiler("bindings_modules_v8_generated_partial_individual") {
40 # Note in GYP this is modules_interface_idl_files but this variable is just 53 # Note in GYP this is modules_interface_idl_files but this variable is just
41 # defined to modules_definition_idl_files. 54 # defined to modules_definition_idl_files.
42 sources = core_idl_with_modules_dependency_files + 55 sources = core_idl_with_modules_dependency_files +
43 webcore_testing_idl_with_modules_dependency_files 56 webcore_testing_idl_with_modules_dependency_files
44 output_dir = bindings_modules_v8_output_dir 57 output_dir = bindings_modules_v8_output_dir
45 output_name_suffix = "Partial" 58 output_name_suffix = "Partial"
46 target_component = "modules" 59 target_component = "modules"
47 } 60 }
48 61
62 # bindings_modules_generated_aggregate in modules/v8/generated.gyp
63 aggregate_generated_bindings(
64 "bindings_modules_v8_generated_partial_aggregate") {
65 sources = core_idl_with_modules_dependency_files
66 component_dir = "modules"
67 is_partial = true
68 outputs = bindings_modules_generated_partial_aggregate_files
69 }
70
49 # GYP version: Source/bindings/modules/v8/generated.gyp:bindings_modules_v8_gene rated_init_partial 71 # GYP version: Source/bindings/modules/v8/generated.gyp:bindings_modules_v8_gene rated_init_partial
50 action("bindings_modules_v8_generated_init_partial") { 72 action("bindings_modules_v8_generated_init_partial") {
51 script = "$bindings_scripts_dir/generate_init_partial_interfaces.py" 73 script = "$bindings_scripts_dir/generate_init_partial_interfaces.py"
52 74
53 inputs = [ 75 inputs = [
54 "$bindings_modules_output_dir/InterfacesInfoOverall.pickle", 76 "$bindings_modules_output_dir/InterfacesInfoOverall.pickle",
55 ] 77 ]
56 outputs = [ 78 outputs = [
57 bindings_modules_generated_init_partial_interfaces_file, 79 bindings_modules_generated_init_partial_interfaces_file,
58 ] 80 ]
59 81
60 # Put the IDL file list in a response file to avoid command-line limits. 82 # Put the IDL file list in a response file to avoid command-line limits.
61 response_file_contents = 83 response_file_contents =
62 rebase_path(core_idl_with_modules_dependency_files, root_build_dir) 84 rebase_path(core_idl_with_modules_dependency_files, root_build_dir)
63 85
64 args = [ 86 args = [
65 "--idl-files-list", 87 "--idl-files-list",
66 "{{response_file_name}}", 88 "{{response_file_name}}",
67 "--output", 89 "--output",
68 rebase_path(bindings_modules_generated_init_partial_interfaces_file, 90 rebase_path(bindings_modules_generated_init_partial_interfaces_file,
69 root_build_dir), 91 root_build_dir),
70 "--write-file-only-if-changed=1", 92 "--write-file-only-if-changed=1",
71 ] 93 ]
72 94
73 deps = [ 95 deps = [
74 "//third_party/WebKit/Source/bindings/modules:interfaces_info", 96 "//third_party/WebKit/Source/bindings/modules:interfaces_info",
75 ] 97 ]
76 } 98 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/BUILD.gn ('k') | third_party/WebKit/Source/bindings/modules/v8/generated.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698