Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

Issue 2325583002: Revert of [Bindings] Remove aggregation of generated binding code (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/modules/v8/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/WebKit/Source/bindings/bindings.gni") 5 import("//third_party/WebKit/Source/bindings/bindings.gni")
6 import("//third_party/WebKit/Source/core/core_idl_files.gni")
6 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni") 7 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
7 import("//third_party/WebKit/Source/core/core.gni") 8 import("//third_party/WebKit/Source/core/core.gni")
8 import("//third_party/WebKit/Source/core/core_idl_files.gni")
9 9
10 visibility = [ "//third_party/WebKit/Source/*" ] 10 visibility = [ "//third_party/WebKit/Source/*" ]
11 11
12 generated_core_dictionary_files = [ 12 generated_core_dictionary_files = [
13 "$blink_core_output_dir/animation/AnimationEffectTimingProperties.cpp", 13 "$blink_core_output_dir/animation/AnimationEffectTimingProperties.cpp",
14 "$blink_core_output_dir/animation/AnimationEffectTimingProperties.h", 14 "$blink_core_output_dir/animation/AnimationEffectTimingProperties.h",
15 "$blink_core_output_dir/animation/ComputedTimingProperties.cpp", 15 "$blink_core_output_dir/animation/ComputedTimingProperties.cpp",
16 "$blink_core_output_dir/animation/ComputedTimingProperties.h", 16 "$blink_core_output_dir/animation/ComputedTimingProperties.h",
17 "$blink_core_output_dir/animation/KeyframeEffectOptions.cpp", 17 "$blink_core_output_dir/animation/KeyframeEffectOptions.cpp",
18 "$blink_core_output_dir/animation/KeyframeEffectOptions.h", 18 "$blink_core_output_dir/animation/KeyframeEffectOptions.h",
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 185
186 generated_core_testing_dictionary_files = [ 186 generated_core_testing_dictionary_files = [
187 "$blink_core_output_dir/testing/InternalDictionary.cpp", 187 "$blink_core_output_dir/testing/InternalDictionary.cpp",
188 "$blink_core_output_dir/testing/InternalDictionary.h", 188 "$blink_core_output_dir/testing/InternalDictionary.h",
189 "$blink_core_output_dir/testing/InternalDictionaryDerived.cpp", 189 "$blink_core_output_dir/testing/InternalDictionaryDerived.cpp",
190 "$blink_core_output_dir/testing/InternalDictionaryDerived.h", 190 "$blink_core_output_dir/testing/InternalDictionaryDerived.h",
191 "$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.cpp", 191 "$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.cpp",
192 "$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.h", 192 "$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.h",
193 ] 193 ]
194 194
195 bindings_core_generated_interface_files = 195 if (is_win && is_official_build) {
196 process_file_template( 196 bindings_core_generated_aggregate_files =
197 core_definition_idl_files, 197 [ "$bindings_core_v8_output_dir/V8GeneratedCoreBindings.cpp" ]
198 [ 198 } else {
199 "$bindings_core_v8_output_dir/V8{{source_name_part}}.cpp", 199 bindings_core_generated_aggregate_files = [
200 "$bindings_core_v8_output_dir/V8{{source_name_part}}.h", 200 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings00.cpp",
201 ]) 201 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings01.cpp",
202 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings02.cpp",
203 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings03.cpp",
204 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings04.cpp",
205 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings05.cpp",
206 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings06.cpp",
207 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings07.cpp",
208 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings08.cpp",
209 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings09.cpp",
210 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings10.cpp",
211 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings11.cpp",
212 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings12.cpp",
213 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings13.cpp",
214 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings14.cpp",
215 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings15.cpp",
216 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings16.cpp",
217 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings17.cpp",
218 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings18.cpp",
219 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings19.cpp",
220 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings20.cpp",
221 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings21.cpp",
222 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings22.cpp",
223 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings23.cpp",
224 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings24.cpp",
225 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings25.cpp",
226 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings26.cpp",
227 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings27.cpp",
228 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings28.cpp",
229 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings29.cpp",
230 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings30.cpp",
231 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings31.cpp",
232 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings32.cpp",
233 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings33.cpp",
234 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings34.cpp",
235 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings35.cpp",
236 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings36.cpp",
237 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings37.cpp",
238 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings38.cpp",
239 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings39.cpp",
240 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings40.cpp",
241 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings41.cpp",
242 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings42.cpp",
243 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings43.cpp",
244 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings44.cpp",
245 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings45.cpp",
246 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings46.cpp",
247 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings47.cpp",
248 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings48.cpp",
249 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings49.cpp",
250 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings50.cpp",
251 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings51.cpp",
252 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings52.cpp",
253 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings53.cpp",
254 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings54.cpp",
255 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings55.cpp",
256 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings56.cpp",
257 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings57.cpp",
258 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings58.cpp",
259 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings59.cpp",
260 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings60.cpp",
261 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings61.cpp",
262 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings62.cpp",
263 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings63.cpp",
264 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings64.cpp",
265 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings65.cpp",
266 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings66.cpp",
267 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings67.cpp",
268 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings68.cpp",
269 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings69.cpp",
270 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings70.cpp",
271 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings71.cpp",
272 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings72.cpp",
273 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings73.cpp",
274 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings74.cpp",
275 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings75.cpp",
276 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings76.cpp",
277 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings77.cpp",
278 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings78.cpp",
279 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings79.cpp",
280 ]
281 }
202 282
203 group("bindings_core_v8_generated") { 283 group("bindings_core_v8_generated") {
204 public_deps = [ 284 public_deps = [
205 ":bindings_core_impl_generated", 285 ":bindings_core_impl_generated",
206 ":generate_bindings_core_v8_interfaces", 286 ":bindings_core_v8_generated_aggregate",
287 ":bindings_core_v8_generated_individual",
207 ] 288 ]
208 } 289 }
209 290
291 aggregate_generated_bindings("bindings_core_v8_generated_aggregate") {
292 sources = core_definition_idl_files
293 component_dir = "core"
294 is_partial = false
295 outputs = bindings_core_generated_aggregate_files
296 }
297
210 # IDL file lists; see: http://www.chromium.org/developers/web-idl-interfaces 298 # IDL file lists; see: http://www.chromium.org/developers/web-idl-interfaces
211 # Interface IDL files: generate individual bindings (includes testing) 299 # Interface IDL files: generate individual bindings (includes testing)
212 idl_compiler("generate_bindings_core_v8_interfaces") { 300 idl_compiler("bindings_core_v8_generated_individual") {
213 sources = core_definition_idl_files + core_testing_definition_idl_files + 301 sources = core_definition_idl_files + core_testing_definition_idl_files +
214 generated_webcore_testing_idl_files 302 generated_webcore_testing_idl_files
215 output_dir = bindings_core_v8_output_dir 303 output_dir = bindings_core_v8_output_dir
216 output_name_suffix = "" 304 output_name_suffix = ""
217 target_component = "core" 305 target_component = "core"
218 } 306 }
219 307
220 idl_impl("bindings_core_impl_generated") { 308 idl_impl("bindings_core_impl_generated") {
221 sources = core_dictionary_idl_files + core_testing_dictionary_idl_files 309 sources = core_dictionary_idl_files + core_testing_dictionary_idl_files
222 outputs = 310 outputs =
223 bindings_core_generated_union_type_files + 311 bindings_core_generated_union_type_files +
224 generated_core_dictionary_files + generated_core_testing_dictionary_files 312 generated_core_dictionary_files + generated_core_testing_dictionary_files
225 output_dir = bindings_core_v8_output_dir 313 output_dir = bindings_core_v8_output_dir
226 target_component = "core" 314 target_component = "core"
227 } 315 }
228 316
229 # Compile the non-test sources generated above. 317 # Compile the non-test sources generated above.
230 blink_core_sources("bindings_core_impl") { 318 blink_core_sources("bindings_core_impl") {
231 sources = 319 sources =
232 bindings_core_generated_union_type_files + 320 bindings_core_generated_union_type_files +
233 generated_core_dictionary_files + bindings_core_generated_interface_files 321 generated_core_dictionary_files + bindings_core_generated_aggregate_files
234 322
235 deps = [ 323 deps = [
236 ":bindings_core_impl_generated", 324 ":bindings_core_impl_generated",
237 ":generate_bindings_core_v8_interfaces", 325 ":bindings_core_v8_generated_aggregate",
238 ] 326 ]
239 } 327 }
240 328
241 # Compile the test sources generated above. This test target doesn't count 329 # Compile the test sources generated above. This test target doesn't count
242 # as part of the "core" component so shouldn't use the blink_core_sources for 330 # as part of the "core" component so shouldn't use the blink_core_sources for
243 # linking on Windows. 331 # linking on Windows.
244 source_set("testing") { 332 source_set("testing") {
245 sources = generated_core_testing_dictionary_files 333 sources = generated_core_testing_dictionary_files
246 334
247 configs -= core_config_remove 335 configs -= core_config_remove
248 configs += [ 336 configs += [
249 "//third_party/WebKit/Source:inside_blink", 337 "//third_party/WebKit/Source:inside_blink",
250 "//third_party/WebKit/Source:config", 338 "//third_party/WebKit/Source:config",
251 ] 339 ]
252 340
253 deps = [ 341 deps = [
254 ":bindings_core_impl_generated", 342 ":bindings_core_impl_generated",
255 "//skia", 343 "//skia",
256 "//third_party/WebKit/Source/wtf", 344 "//third_party/WebKit/Source/wtf",
257 "//v8", 345 "//v8",
258 ] 346 ]
259 } 347 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/modules/v8/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698