Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2325153002: Remove memory metrics from WebRTC measurements. (Closed)

Created:
4 years, 3 months ago by phoglund_chromium
Modified:
4 years, 3 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove memory metrics from WebRTC measurements. We need to rewrite to tbm2 in order to get memory. We don't really look at memory metrics anyway at this point, so remove for now. BUG=632295 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/37df9608746ce0bebf92918e1d011e02b5243528 Cr-Commit-Position: refs/heads/master@{#417603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M tools/perf/measurements/webrtc.py View 4 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
phoglund_chromium
4 years, 3 months ago (2016-09-09 13:49:54 UTC) #3
sullivan
lgtm
4 years, 3 months ago (2016-09-09 14:26:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325153002/1
4 years, 3 months ago (2016-09-09 14:31:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 16:46:05 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 16:48:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37df9608746ce0bebf92918e1d011e02b5243528
Cr-Commit-Position: refs/heads/master@{#417603}

Powered by Google App Engine
This is Rietveld 408576698