Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: tools/perf/measurements/webrtc.py

Issue 2325153002: Remove memory metrics from WebRTC measurements. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/webrtc.py
diff --git a/tools/perf/measurements/webrtc.py b/tools/perf/measurements/webrtc.py
index 9735e4aa7c21124ea9fc74ee4d24d246c3b1bf0f..90061f8ea7e1a162c50556c3bd6cb591931affc6 100644
--- a/tools/perf/measurements/webrtc.py
+++ b/tools/perf/measurements/webrtc.py
@@ -6,7 +6,6 @@ from telemetry.page import legacy_page_test
from metrics import cpu
from metrics import media
-from metrics import memory
from metrics import power
from metrics import webrtc_stats
@@ -18,7 +17,6 @@ class WebRTC(legacy_page_test.LegacyPageTest):
super(WebRTC, self).__init__()
self._cpu_metric = None
self._media_metric = None
- self._memory_metric = None
self._power_metric = None
self._webrtc_stats_metric = None
@@ -27,19 +25,16 @@ class WebRTC(legacy_page_test.LegacyPageTest):
def DidStartBrowser(self, browser):
self._cpu_metric = cpu.CpuMetric(browser)
- self._memory_metric = memory.MemoryMetric(browser)
self._webrtc_stats_metric = webrtc_stats.WebRtcStatisticsMetric()
def DidNavigateToPage(self, page, tab):
self._cpu_metric.Start(page, tab)
self._media_metric = media.MediaMetric(tab)
self._media_metric.Start(page, tab)
- self._memory_metric.Start(page, tab)
self._power_metric.Start(page, tab)
self._webrtc_stats_metric.Start(page, tab)
def CustomizeBrowserOptions(self, options):
- memory.MemoryMetric.CustomizeBrowserOptions(options)
options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream')
options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream')
power.PowerMetric.CustomizeBrowserOptions(options)
@@ -55,9 +50,6 @@ class WebRTC(legacy_page_test.LegacyPageTest):
self._media_metric.Stop(page, tab)
self._media_metric.AddResults(tab, results, exclude_metrics=exclude_metrics)
- self._memory_metric.Stop(page, tab)
- self._memory_metric.AddResults(tab, results)
-
self._power_metric.Stop(page, tab)
self._power_metric.AddResults(tab, results)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698