Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: tools/perf/measurements/webrtc.py

Issue 2325153002: Remove memory metrics from WebRTC measurements. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.page import legacy_page_test 5 from telemetry.page import legacy_page_test
6 6
7 from metrics import cpu 7 from metrics import cpu
8 from metrics import media 8 from metrics import media
9 from metrics import memory
10 from metrics import power 9 from metrics import power
11 from metrics import webrtc_stats 10 from metrics import webrtc_stats
12 11
13 12
14 class WebRTC(legacy_page_test.LegacyPageTest): 13 class WebRTC(legacy_page_test.LegacyPageTest):
15 """Gathers WebRTC-related metrics on a page set.""" 14 """Gathers WebRTC-related metrics on a page set."""
16 15
17 def __init__(self): 16 def __init__(self):
18 super(WebRTC, self).__init__() 17 super(WebRTC, self).__init__()
19 self._cpu_metric = None 18 self._cpu_metric = None
20 self._media_metric = None 19 self._media_metric = None
21 self._memory_metric = None
22 self._power_metric = None 20 self._power_metric = None
23 self._webrtc_stats_metric = None 21 self._webrtc_stats_metric = None
24 22
25 def WillStartBrowser(self, platform): 23 def WillStartBrowser(self, platform):
26 self._power_metric = power.PowerMetric(platform) 24 self._power_metric = power.PowerMetric(platform)
27 25
28 def DidStartBrowser(self, browser): 26 def DidStartBrowser(self, browser):
29 self._cpu_metric = cpu.CpuMetric(browser) 27 self._cpu_metric = cpu.CpuMetric(browser)
30 self._memory_metric = memory.MemoryMetric(browser)
31 self._webrtc_stats_metric = webrtc_stats.WebRtcStatisticsMetric() 28 self._webrtc_stats_metric = webrtc_stats.WebRtcStatisticsMetric()
32 29
33 def DidNavigateToPage(self, page, tab): 30 def DidNavigateToPage(self, page, tab):
34 self._cpu_metric.Start(page, tab) 31 self._cpu_metric.Start(page, tab)
35 self._media_metric = media.MediaMetric(tab) 32 self._media_metric = media.MediaMetric(tab)
36 self._media_metric.Start(page, tab) 33 self._media_metric.Start(page, tab)
37 self._memory_metric.Start(page, tab)
38 self._power_metric.Start(page, tab) 34 self._power_metric.Start(page, tab)
39 self._webrtc_stats_metric.Start(page, tab) 35 self._webrtc_stats_metric.Start(page, tab)
40 36
41 def CustomizeBrowserOptions(self, options): 37 def CustomizeBrowserOptions(self, options):
42 memory.MemoryMetric.CustomizeBrowserOptions(options)
43 options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream') 38 options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream')
44 options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream') 39 options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream')
45 power.PowerMetric.CustomizeBrowserOptions(options) 40 power.PowerMetric.CustomizeBrowserOptions(options)
46 41
47 def ValidateAndMeasurePage(self, page, tab, results): 42 def ValidateAndMeasurePage(self, page, tab, results):
48 """Measure the page's performance.""" 43 """Measure the page's performance."""
49 self._cpu_metric.Stop(page, tab) 44 self._cpu_metric.Stop(page, tab)
50 self._cpu_metric.AddResults(tab, results) 45 self._cpu_metric.AddResults(tab, results)
51 46
52 # Add all media metrics except bytes (those aren't hooked up for WebRTC 47 # Add all media metrics except bytes (those aren't hooked up for WebRTC
53 # video tags). 48 # video tags).
54 exclude_metrics = ['decoded_video_bytes', 'decoded_audio_bytes'] 49 exclude_metrics = ['decoded_video_bytes', 'decoded_audio_bytes']
55 self._media_metric.Stop(page, tab) 50 self._media_metric.Stop(page, tab)
56 self._media_metric.AddResults(tab, results, exclude_metrics=exclude_metrics) 51 self._media_metric.AddResults(tab, results, exclude_metrics=exclude_metrics)
57 52
58 self._memory_metric.Stop(page, tab)
59 self._memory_metric.AddResults(tab, results)
60
61 self._power_metric.Stop(page, tab) 53 self._power_metric.Stop(page, tab)
62 self._power_metric.AddResults(tab, results) 54 self._power_metric.AddResults(tab, results)
63 55
64 self._webrtc_stats_metric.Stop(page, tab) 56 self._webrtc_stats_metric.Stop(page, tab)
65 self._webrtc_stats_metric.AddResults(tab, results) 57 self._webrtc_stats_metric.AddResults(tab, results)
66 58
67 def DidRunPage(self, platform): 59 def DidRunPage(self, platform):
68 del platform # unused 60 del platform # unused
69 self._power_metric.Close() 61 self._power_metric.Close()
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698