Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2324903002: Subzero, MIPS32: Handling fptrunc and fpext casting (Closed)

Created:
4 years, 3 months ago by obucinac
Modified:
4 years, 3 months ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero, MIPS32: Handling fptrunc and fpext casting Patch implements truncation and extension of FP values. R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5a9f714f247a2b7a30fc536e46d9c409fe5294c2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M src/IceTargetLoweringMIPS32.cpp View 1 chunk +16 lines, -7 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.convert.ll View 3 chunks +9 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
obucinac
4 years, 3 months ago (2016-09-08 18:26:38 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/2324903002/diff/1/tests_lit/llvm2ice_tests/fp.convert.ll File tests_lit/llvm2ice_tests/fp.convert.ll (right): https://codereview.chromium.org/2324903002/diff/1/tests_lit/llvm2ice_tests/fp.convert.ll#newcode19 tests_lit/llvm2ice_tests/fp.convert.ll:19: ; RUN: %if --need=allow_dump --need=target_MIPS32 --command %p2i --filetype=asm ...
4 years, 3 months ago (2016-09-11 14:08:19 UTC) #4
Jim Stichnoth
4 years, 3 months ago (2016-09-11 14:08:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5a9f714f247a2b7a30fc536e46d9c409fe5294c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698