Issue 2324883002: [Offline Pages] Simple, mergable fix to no longer report a request completed when it is FOREGROUND_…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2324883002: [Offline Pages] Simple, mergable fix to no longer report a request completed when it is FOREGROUND_… (Closed)

Created:
4 years, 3 months ago by Pete Williamson

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

[Offline Pages] Simple, mergable fix to no longer report a request completed when it is FOREGROUND_CANCELED or PRERENDERING_CANCELED and subject to retry. BUG=644444 Review-Url: https://codereview.chromium.org/2326593002 Cr-Commit-Position: refs/heads/master@{#417328} (cherry picked from commit f9c01aee8aef23aaa838c71fc2df65254b344131) Committed: https://chromium.googlesource.com/chromium/src/+/e6a47a78adea9f959e5df0ea4b21279abc78055f

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	components/offline_pages/background/request_coordinator.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download

Total messages: 2 (1 generated)

Pete Williamson

4 years, 3 months ago (2016-09-08 18:05:08 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e6a47a78adea9f959e5df0ea4b21279abc78055f.