Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2324883002: [Offline Pages] Simple, mergable fix to no longer report a request completed when it is FOREGROUND_… (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index e4b30799cc918c92ceeb66e7567a0ac7a480eacd..9f2fdc2580ae550ce00dabe7dc79b76e66a84f10 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -447,11 +447,7 @@ void RequestCoordinator::OfflinerDoneCallback(const SavePageRequest& request,
// aborted cases to treat this way (eg, for Render Process Killed).
SavePageRequest updated_request(request);
AbortRequestAttempt(&updated_request);
- SavePageStatus notify_status =
- (status == Offliner::RequestStatus::FOREGROUND_CANCELED)
- ? SavePageStatus::FOREGROUND_CANCELED
- : SavePageStatus::PRERENDER_CANCELED;
- NotifyCompleted(updated_request, notify_status);
+ NotifyChanged(updated_request);
} else if (status == Offliner::RequestStatus::SAVED) {
// Remove the request from the queue if it succeeded.
RemoveAttemptedRequest(request, SavePageStatus::SUCCESS);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698