Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2326593002: [Offline Pages] Simple, mergable fix to no longer report a request completed when it is FOREGROUND_… (Closed)

Created:
4 years, 3 months ago by dougarnett
Modified:
4 years, 3 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Simple, mergable fix to no longer report a request completed when it is FOREGROUND_CANCELED or PRERENDERING_CANCELED and subject to retry. BUG=644444 Committed: https://crrev.com/f9c01aee8aef23aaa838c71fc2df65254b344131 Cr-Commit-Position: refs/heads/master@{#417328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M components/offline_pages/background/request_coordinator.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
dougarnett
Here is the simple fix. I verified it end-to-end for my repro case.
4 years, 3 months ago (2016-09-08 16:41:32 UTC) #4
fgorski
lgtm
4 years, 3 months ago (2016-09-08 16:50:22 UTC) #5
Pete Williamson
lgtm
4 years, 3 months ago (2016-09-08 16:52:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326593002/1
4 years, 3 months ago (2016-09-08 16:54:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326593002/1
4 years, 3 months ago (2016-09-08 16:55:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 17:38:39 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 17:41:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9c01aee8aef23aaa838c71fc2df65254b344131
Cr-Commit-Position: refs/heads/master@{#417328}

Powered by Google App Engine
This is Rietveld 408576698