Fix storage of gamut transform matrices in SkColorSpace

Fix storage of gamut transform matrices in SkColorSpace

We were effectively storing the transpose, which made all of our
operations on individual colors, and our concatenation of matrices
awkward and backwards.

I'm planning to push this further into Ganesh, where I had incorrectly
adjusted to the previous layout, treating colors as row vectors in the
shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324843003

Committed: https://skia.googlesource.com/skia/+/de68d6c4616d86621373d88100002ddfdb9c08e3

[Brian Osman, 2016-09-08 21:33:21]

Description was changed from

==========
Fix storage of gamut transform matrices in SkColorSpace

We were effectively storing the transpose, which made all of our
operations on individual colors, and our concatenation of matrices
awkward and backwards.

I'm planning to push this further into Ganesh, where I had incorrectly
adjusted to the previous layout, treating colors as row vectors in the
shaders.

BUG=skia:
==========

to

==========
Fix storage of gamut transform matrices in SkColorSpace

We were effectively storing the transpose, which made all of our
operations on individual colors, and our concatenation of matrices
awkward and backwards.

I'm planning to push this further into Ganesh, where I had incorrectly
adjusted to the previous layout, treating colors as row vectors in the
shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324843003
==========

[Brian Osman, 2016-09-08 21:33:30]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 21:33:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-09-08 21:38:56]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, msarett@google.com, mtklein@google.com, reed@google.com

[msarett, 2016-09-08 21:43:48]

lgtm

https://codereview.chromium.org/2324843003/diff/1/src/core/SkColorSpaceXform.cpp
File src/core/SkColorSpaceXform.cpp (left):

https://codereview.chromium.org/2324843003/diff/1/src/core/SkColorSpaceXform....
src/core/SkColorSpaceXform.cpp:449: static inline void
compute_gamut_xform(SkMatrix44* srcToDst, const SkColorSpace* src,
Thanks for inlining :)

[commit-bot: I haz the power, 2016-09-08 22:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:11:15]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-09-08 23:11:02]

api lgtm

[Brian Osman, 2016-09-09 17:35:10]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-09-09 17:35:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 17:36:20]

Description was changed from

==========
Fix storage of gamut transform matrices in SkColorSpace

We were effectively storing the transpose, which made all of our
operations on individual colors, and our concatenation of matrices
awkward and backwards.

I'm planning to push this further into Ganesh, where I had incorrectly
adjusted to the previous layout, treating colors as row vectors in the
shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324843003
==========

to

==========
Fix storage of gamut transform matrices in SkColorSpace

We were effectively storing the transpose, which made all of our
operations on individual colors, and our concatenation of matrices
awkward and backwards.

I'm planning to push this further into Ganesh, where I had incorrectly
adjusted to the previous layout, treating colors as row vectors in the
shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324843003

Committed:
https://skia.googlesource.com/skia/+/de68d6c4616d86621373d88100002ddfdb9c08e3
==========

[commit-bot: I haz the power, 2016-09-09 17:36:21]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/de68d6c4616d86621373d88100002ddfdb9c08e3