Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: src/gpu/GrColorSpaceXform.cpp

Issue 2324843003: Fix storage of gamut transform matrices in SkColorSpace (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "GrColorSpaceXform.h" 8 #include "GrColorSpaceXform.h"
9 #include "SkColorSpace.h" 9 #include "SkColorSpace.h"
10 #include "SkColorSpace_Base.h" 10 #include "SkColorSpace_Base.h"
(...skipping 19 matching lines...) Expand all
30 sk_float_almost_equals(m.getFloat(2, 2), 1.0f, tol) && 30 sk_float_almost_equals(m.getFloat(2, 2), 1.0f, tol) &&
31 sk_float_almost_equals(m.getFloat(2, 3), 0.0f, tol) && 31 sk_float_almost_equals(m.getFloat(2, 3), 0.0f, tol) &&
32 sk_float_almost_equals(m.getFloat(3, 0), 0.0f, tol) && 32 sk_float_almost_equals(m.getFloat(3, 0), 0.0f, tol) &&
33 sk_float_almost_equals(m.getFloat(3, 1), 0.0f, tol) && 33 sk_float_almost_equals(m.getFloat(3, 1), 0.0f, tol) &&
34 sk_float_almost_equals(m.getFloat(3, 2), 0.0f, tol) && 34 sk_float_almost_equals(m.getFloat(3, 2), 0.0f, tol) &&
35 sk_float_almost_equals(m.getFloat(3, 3), 1.0f, tol); 35 sk_float_almost_equals(m.getFloat(3, 3), 1.0f, tol);
36 } 36 }
37 37
38 GrColorSpaceXform::GrColorSpaceXform(const SkMatrix44& srcToDst, SkAlphaType src AlphaType) 38 GrColorSpaceXform::GrColorSpaceXform(const SkMatrix44& srcToDst, SkAlphaType src AlphaType)
39 : fSrcAlphaType(srcAlphaType) { 39 : fSrcAlphaType(srcAlphaType) {
40 srcToDst.asColMajorf(fSrcToDst); 40 // TODO: Fix this, and store things as column major!
41 srcToDst.asRowMajorf(fSrcToDst);
41 } 42 }
42 43
43 sk_sp<GrColorSpaceXform> GrColorSpaceXform::Make(SkColorSpace* src, SkColorSpace * dst, 44 sk_sp<GrColorSpaceXform> GrColorSpaceXform::Make(SkColorSpace* src, SkColorSpace * dst,
44 SkAlphaType srcAlphaType) { 45 SkAlphaType srcAlphaType) {
45 if (!src || !dst) { 46 if (!src || !dst) {
46 // Invalid 47 // Invalid
47 return nullptr; 48 return nullptr;
48 } 49 }
49 50
50 if (src == dst) { 51 if (src == dst) {
51 // Quick equality check - no conversion needed in this case 52 // Quick equality check - no conversion needed in this case
52 return nullptr; 53 return nullptr;
53 } 54 }
54 55
55 SkMatrix44 srcToDst = as_CSB(dst)->fromXYZD50(); 56 SkMatrix44 srcToDst(SkMatrix44::kUninitialized_Constructor);
56 srcToDst.postConcat(src->toXYZD50()); 57 srcToDst.setConcat(as_CSB(dst)->fromXYZD50(), src->toXYZD50());
57 58
58 if (matrix_is_almost_identity(srcToDst)) { 59 if (matrix_is_almost_identity(srcToDst)) {
59 return nullptr; 60 return nullptr;
60 } 61 }
61 62
62 return sk_make_sp<GrColorSpaceXform>(srcToDst, srcAlphaType); 63 return sk_make_sp<GrColorSpaceXform>(srcToDst, srcAlphaType);
63 } 64 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698