Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2323393004: Complete removing Blink gyp files. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tzik, mlamouri+watch-screen-orientation_chromium.org, johnme+watch_chromium.org, eric.carlson_apple.com, Srirama, timvolodine, awdf+watch_chromium.org, jkarlin+watch_chromium.org, blink-reviews, gyuyoung2, harkness+watch_chromium.org, mcasas+watch+mediastream_chromium.org, Peter Beverloo, nhiroki, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, mcasas+watch+mediarecorder_chromium.org, haraken, jsbell+idb_chromium.org, emircan+watch+mediarecorder_chromium.org, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, cmumford, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Complete removing Blink gyp files. Move the remaining modules sources into subdirectories. Update the toplevel .gn file to remove all the now-obsolete references to gypi_to_gn.py exec_script calls. R=dpranke@chromium.org Committed: https://crrev.com/de7b265816adaad444e1dbdfe306d2a16539d9cd Cr-Commit-Position: refs/heads/master@{#417760}

Patch Set 1 #

Patch Set 2 : Remove more #

Patch Set 3 : merge #

Patch Set 4 : Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+657 lines, -1024 lines) Patch
M .gn View 1 2 3 3 chunks +4 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/config.gni View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 3 chunks +29 lines, -5 lines 0 comments Download
A third_party/WebKit/Source/modules/filesystem/BUILD.gn View 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/gamepad/BUILD.gn View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/geolocation/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/imagebitmap/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/modules/imagecapture/BUILD.gn View 1 chunk +7 lines, -6 lines 0 comments Download
A third_party/WebKit/Source/modules/indexeddb/BUILD.gn View 1 chunk +67 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/installedapp/BUILD.gn View 1 chunk +6 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/modules/mediacapturefromelement/BUILD.gn View 1 chunk +22 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/mediarecorder/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/modules/mediasession/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediasource/BUILD.gn View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/BUILD.gn View 1 chunk +50 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gni View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/Source/modules/modules.gypi View 1 chunk +0 lines, -430 lines 0 comments Download
A + third_party/WebKit/Source/modules/navigatorcontentutils/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/modules/netinfo/BUILD.gn View 1 chunk +16 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/nfc/BUILD.gn View 1 chunk +8 lines, -6 lines 0 comments Download
A third_party/WebKit/Source/modules/notifications/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/offscreencanvas/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/modules/offscreencanvas2d/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/modules/payments/BUILD.gn View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/peerconnection/BUILD.gn View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/permissions/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/plugins/BUILD.gn View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/presentation/BUILD.gn View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/push_messaging/BUILD.gn View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/quota/BUILD.gn View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/remoteplayback/BUILD.gn View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/screen_orientation/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/inspector_protocol.gypi View 1 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/public/all.gyp View 1 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/public/blink.gyp View 1 1 chunk +0 lines, -254 lines 0 comments Download
D third_party/WebKit/public/blink_devtools.gyp View 1 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/public/blink_headers.gyp View 1 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/public/blink_resources.gyp View 1 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
brettw
4 years, 3 months ago (2016-09-09 20:12:11 UTC) #4
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-09 20:16:17 UTC) #7
brettw
merge
4 years, 3 months ago (2016-09-09 21:40:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323393004/40001
4 years, 3 months ago (2016-09-09 21:40:44 UTC) #14
brettw
Windows
4 years, 3 months ago (2016-09-09 21:48:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323393004/60001
4 years, 3 months ago (2016-09-09 21:48:56 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-09 23:25:27 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 23:28:23 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/de7b265816adaad444e1dbdfe306d2a16539d9cd
Cr-Commit-Position: refs/heads/master@{#417760}

Powered by Google App Engine
This is Rietveld 408576698