third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp - Issue 2324103002: Cleanup EXPECT/ASSERTs in unit tests in core/fetch and core/loader

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

Issue 2324103002: Cleanup EXPECT/ASSERTs in unit tests in core/fetch and core/loader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp ('K') | « third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp ('k') | third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp » ('j') | third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

index 1aa1e619c42412c2ad61033dd701bea480e6dac0..5d25d14c984369cb02d0de6b9d5754aab6c08b31 100644

--- a/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

@@ -590,11 +590,11 @@ TEST_F(FrameFetchContextTest, SetIsExternalRequestForPublicDocument)

SCOPED_TRACE(test.url);

ResourceRequest mainRequest(test.url);

fetchContext->addAdditionalRequestHeaders(mainRequest, FetchMainResource);

- EXPECT_EQ(mainRequest.isExternalRequest(), test.isExternalExpectation);

+ EXPECT_EQ(test.isExternalExpectation, mainRequest.isExternalRequest());

ResourceRequest subRequest(test.url);

fetchContext->addAdditionalRequestHeaders(subRequest, FetchSubresource);

- EXPECT_EQ(subRequest.isExternalRequest(), test.isExternalExpectation);

+ EXPECT_EQ(test.isExternalExpectation, subRequest.isExternalRequest());

}

@@ -638,11 +638,11 @@ TEST_F(FrameFetchContextTest, SetIsExternalRequestForPrivateDocument)

SCOPED_TRACE(test.url);

ResourceRequest mainRequest(test.url);

fetchContext->addAdditionalRequestHeaders(mainRequest, FetchMainResource);

- EXPECT_EQ(mainRequest.isExternalRequest(), test.isExternalExpectation);

+ EXPECT_EQ(test.isExternalExpectation, mainRequest.isExternalRequest());

ResourceRequest subRequest(test.url);

fetchContext->addAdditionalRequestHeaders(subRequest, FetchSubresource);

- EXPECT_EQ(subRequest.isExternalRequest(), test.isExternalExpectation);

+ EXPECT_EQ(test.isExternalExpectation, subRequest.isExternalRequest());

}

@@ -685,11 +685,11 @@ TEST_F(FrameFetchContextTest, SetIsExternalRequestForLocalDocument)

for (const auto& test : cases) {

ResourceRequest mainRequest(test.url);

fetchContext->addAdditionalRequestHeaders(mainRequest, FetchMainResource);

- EXPECT_EQ(mainRequest.isExternalRequest(), test.isExternalExpectation);

+ EXPECT_EQ(test.isExternalExpectation, mainRequest.isExternalRequest());

ResourceRequest subRequest(test.url);

fetchContext->addAdditionalRequestHeaders(subRequest, FetchSubresource);

- EXPECT_EQ(subRequest.isExternalRequest(), test.isExternalExpectation);

+ EXPECT_EQ(test.isExternalExpectation, subRequest.isExternalRequest());

}