Cleanup EXPECT/ASSERTs in unit tests in core/fetch and core/loader

third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

 /*
  * Copyright (c) 2015, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 168 matching lines @@
     {
         KURL inputURL(ParsedURLString, input);
         KURL expectedURL(ParsedURLString, expected);
 
         FetchRequest fetchRequest = FetchRequest(ResourceRequest(inputURL), FetchInitiatorInfo());
         fetchRequest.mutableResourceRequest().setRequestContext(requestContext);
         fetchRequest.mutableResourceRequest().setFrameType(frameType);
 
         fetchContext->upgradeInsecureRequest(fetchRequest.mutableResourceRequest());
 
         EXPECT_STREQ(expectedURL.getString().utf8().data(), fetchRequest.resourceRequest().url().getString().utf8().data());

[yhirano, 2016/09/09 07:34:48]

You can use EXPECT_EQ.

[hiroshige, 2016/09/09 08:11:35]

Done.

         EXPECT_EQ(expectedURL.protocol(), fetchRequest.resourceRequest().url().protocol());
         EXPECT_EQ(expectedURL.host(), fetchRequest.resourceRequest().url().host());
         EXPECT_EQ(expectedURL.port(), fetchRequest.resourceRequest().url().port());
         EXPECT_EQ(expectedURL.hasPort(), fetchRequest.resourceRequest().url().hasPort());
         EXPECT_EQ(expectedURL.path(), fetchRequest.resourceRequest().url().path());
     }
 
     void expectHTTPSHeader(const char* input, WebURLRequest::FrameType frameType, bool shouldPrefer)
     {
         KURL inputURL(ParsedURLString, input);
 
         FetchRequest fetchRequest = FetchRequest(ResourceRequest(inputURL), FetchInitiatorInfo());
         fetchRequest.mutableResourceRequest().setRequestContext(WebURLRequest::RequestContextScript);
         fetchRequest.mutableResourceRequest().setFrameType(frameType);
 
         fetchContext->upgradeInsecureRequest(fetchRequest.mutableResourceRequest());
 
         EXPECT_STREQ(shouldPrefer ? "1" : "",

[yhirano, 2016/09/09 07:34:48]

You can use EXPECT_EQ.

[hiroshige, 2016/09/09 08:11:36]

Done.

             fetchRequest.resourceRequest().httpHeaderField(HTTPNames::Upgrade_Insecure_Requests).utf8().data());
 
         // Calling upgradeInsecureRequest more than once shouldn't affect the header.
         if (shouldPrefer) {
             fetchContext->upgradeInsecureRequest(fetchRequest.mutableResourceRequest());
             EXPECT_STREQ("1", fetchRequest.resourceRequest().httpHeaderField(HTTPNames::Upgrade_Insecure_Requests).utf8().data());

[yhirano, 2016/09/09 07:34:48]

ditto

[hiroshige, 2016/09/09 08:11:35]

Done.

         }
     }
 
     RefPtr<SecurityOrigin> exampleOrigin;
     RefPtr<SecurityOrigin> secureOrigin;
 };
 
 TEST_F(FrameFetchContextUpgradeTest, UpgradeInsecureResourceRequests)
 {
     struct TestCase {
@@ skipping 292 matching lines @@
     EXPECT_EQ(ResourceLoadPriorityVeryLow, childFetchContext->modifyPriorityForExperiments(ResourceLoadPriorityVeryHigh));
     EXPECT_EQ(ResourceLoadPriorityVeryLow, childFetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium));
 }
 
 TEST_F(FrameFetchContextTest, EnableDataSaver)
 {
     Settings* settings = document->frame()->settings();
     settings->setDataSaverEnabled(true);
     ResourceRequest resourceRequest("http://www.example.com");
     fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
     EXPECT_STREQ("on", resourceRequest.httpHeaderField("Save-Data").utf8().data());

[yhirano, 2016/09/09 07:34:48]

You can use EXPECT_EQ.

[hiroshige, 2016/09/09 08:11:35]

Done.

 
     // Subsequent call to addAdditionalRequestHeaders should not append to the
     // save-data header.
     fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
     EXPECT_STREQ("on", resourceRequest.httpHeaderField("Save-Data").utf8().data());

[yhirano, 2016/09/09 07:34:48]

ditto.

[hiroshige, 2016/09/09 08:11:36]

Done.

 }
 
 TEST_F(FrameFetchContextTest, DisabledDataSaver)
 {
     ResourceRequest resourceRequest("http://www.example.com");
     fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
     EXPECT_STREQ("", resourceRequest.httpHeaderField("Save-Data").utf8().data());

[yhirano, 2016/09/09 07:34:48]

ditto (or isEmpty is better?)

[hiroshige, 2016/09/09 08:11:35]

Done.

 }
 
 // Tests that when a resource with certificate errors is loaded from the
 // memory cache, the embedder is notified.
 TEST_F(FrameFetchContextDisplayedCertificateErrorsTest, MemoryCacheCertificateError)
 {
     ResourceRequest resourceRequest(url);
     ResourceResponse response;
     response.setURL(url);
     response.setHasMajorCertificateErrors(true);
@@ skipping 34 matching lines @@
         ResourceRequest subRequest(test.url);
         fetchContext->addAdditionalRequestHeaders(subRequest, FetchSubresource);
         EXPECT_FALSE(subRequest.isExternalRequest());
     }
 
     RuntimeEnabledFeatures::setCorsRFC1918Enabled(true);
     for (const auto& test : cases) {
         SCOPED_TRACE(test.url);
         ResourceRequest mainRequest(test.url);
         fetchContext->addAdditionalRequestHeaders(mainRequest, FetchMainResource);
-        EXPECT_EQ(mainRequest.isExternalRequest(), test.isExternalExpectation);
+        EXPECT_EQ(test.isExternalExpectation, mainRequest.isExternalRequest());
 
         ResourceRequest subRequest(test.url);
         fetchContext->addAdditionalRequestHeaders(subRequest, FetchSubresource);
-        EXPECT_EQ(subRequest.isExternalRequest(), test.isExternalExpectation);
+        EXPECT_EQ(test.isExternalExpectation, subRequest.isExternalRequest());
     }
 }
 
 TEST_F(FrameFetchContextTest, SetIsExternalRequestForPrivateDocument)
 {
     document->setAddressSpace(WebAddressSpacePrivate);
     EXPECT_EQ(WebAddressSpacePrivate, document->addressSpace());
 
     struct TestCase {
         const char* url;
@@ skipping 23 matching lines @@
         ResourceRequest subRequest(test.url);
         fetchContext->addAdditionalRequestHeaders(subRequest, FetchSubresource);
         EXPECT_FALSE(subRequest.isExternalRequest());
     }
 
     RuntimeEnabledFeatures::setCorsRFC1918Enabled(true);
     for (const auto& test : cases) {
         SCOPED_TRACE(test.url);
         ResourceRequest mainRequest(test.url);
         fetchContext->addAdditionalRequestHeaders(mainRequest, FetchMainResource);
-        EXPECT_EQ(mainRequest.isExternalRequest(), test.isExternalExpectation);
+        EXPECT_EQ(test.isExternalExpectation, mainRequest.isExternalRequest());
 
         ResourceRequest subRequest(test.url);
         fetchContext->addAdditionalRequestHeaders(subRequest, FetchSubresource);
-        EXPECT_EQ(subRequest.isExternalRequest(), test.isExternalExpectation);
+        EXPECT_EQ(test.isExternalExpectation, subRequest.isExternalRequest());
     }
 }
 
 TEST_F(FrameFetchContextTest, SetIsExternalRequestForLocalDocument)
 {
     document->setAddressSpace(WebAddressSpaceLocal);
     EXPECT_EQ(WebAddressSpaceLocal, document->addressSpace());
 
     struct TestCase {
         const char* url;
@@ skipping 22 matching lines @@
 
         ResourceRequest subRequest(test.url);
         fetchContext->addAdditionalRequestHeaders(subRequest, FetchSubresource);
         EXPECT_FALSE(subRequest.isExternalRequest());
     }
 
     RuntimeEnabledFeatures::setCorsRFC1918Enabled(true);
     for (const auto& test : cases) {
         ResourceRequest mainRequest(test.url);
         fetchContext->addAdditionalRequestHeaders(mainRequest, FetchMainResource);
-        EXPECT_EQ(mainRequest.isExternalRequest(), test.isExternalExpectation);
+        EXPECT_EQ(test.isExternalExpectation, mainRequest.isExternalRequest());
 
         ResourceRequest subRequest(test.url);
         fetchContext->addAdditionalRequestHeaders(subRequest, FetchSubresource);
-        EXPECT_EQ(subRequest.isExternalRequest(), test.isExternalExpectation);
+        EXPECT_EQ(test.isExternalExpectation, subRequest.isExternalRequest());
     }
 }
 
 } // namespace blink