third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp - Issue 2324103002: Cleanup EXPECT/ASSERTs in unit tests in core/fetch and core/loader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

Issue 2324103002: Cleanup EXPECT/ASSERTs in unit tests in core/fetch and core/loader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/RawResourceTest.cpp ('k') | third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp » ('j') | third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

index 9f748b065c1532afcb9df30f011593bba130eb7c..bb2aff3f39d7120ed41018b05f47e64beb377bac 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

@@ -121,8 +121,8 @@ TEST_F(ResourceFetcherTest, StartLoadAfterFrameDetach)

ResourceFetcher* fetcher = ResourceFetcher::create(nullptr);

FetchRequest fetchRequest = FetchRequest(ResourceRequest(secureURL), FetchInitiatorInfo());

Resource* resource = fetcher->requestResource(fetchRequest, TestResourceFactory());

- EXPECT_EQ(resource, static_cast<Resource*>(nullptr));

- EXPECT_EQ(memoryCache()->resourceForURL(secureURL), static_cast<Resource*>(nullptr));

+ EXPECT_FALSE(resource);

+ EXPECT_FALSE(memoryCache()->resourceForURL(secureURL));

// Start by calling startLoad() directly, rather than via requestResource().

// This shouldn't crash.