Source/core/rendering/style/RenderStyle.cpp - Issue 23241010: Support subpixel values for text-shadow and box-shadow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/RenderStyle.cpp

Issue 23241010: Support subpixel values for text-shadow and box-shadow (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: found one more spot Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/animations/resources/animation-test-helpers.js ('K') | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/core/rendering/style/ShadowData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/style/RenderStyle.cpp

diff --git a/Source/core/rendering/style/RenderStyle.cpp b/Source/core/rendering/style/RenderStyle.cpp

index 220362ec18f89e3f2d933a01172049017ab6ec04..b960d8003d933b1339bc85042347d65e49f95b63 100644

--- a/Source/core/rendering/style/RenderStyle.cpp

+++ b/Source/core/rendering/style/RenderStyle.cpp

@@ -1233,7 +1233,7 @@ void RenderStyle::getShadowExtent(const ShadowData* shadow, LayoutUnit &top, Lay

for ( ; shadow; shadow = shadow->next()) {

if (shadow->style() == Inset)

continue;

- int blurAndSpread = shadow->blur() + shadow->spread();

+ LayoutUnit blurAndSpread = shadow->blur() + shadow->spread();

top = min<LayoutUnit>(top, shadow->y() - blurAndSpread);

right = max<LayoutUnit>(right, shadow->x() + blurAndSpread);

@@ -1252,7 +1252,7 @@ LayoutBoxExtent RenderStyle::getShadowInsetExtent(const ShadowData* shadow) cons

for ( ; shadow; shadow = shadow->next()) {

if (shadow->style() == Normal)

continue;

- int blurAndSpread = shadow->blur() + shadow->spread();

+ LayoutUnit blurAndSpread = shadow->blur() + shadow->spread();

top = max<LayoutUnit>(top, shadow->y() + blurAndSpread);

right = min<LayoutUnit>(right, shadow->x() - blurAndSpread);

bottom = min<LayoutUnit>(bottom, shadow->y() - blurAndSpread);

@@ -1270,7 +1270,7 @@ void RenderStyle::getShadowHorizontalExtent(const ShadowData* shadow, LayoutUnit

for ( ; shadow; shadow = shadow->next()) {

if (shadow->style() == Inset)

continue;

- int blurAndSpread = shadow->blur() + shadow->spread();

+ LayoutUnit blurAndSpread = shadow->blur() + shadow->spread();

left = min<LayoutUnit>(left, shadow->x() - blurAndSpread);

right = max<LayoutUnit>(right, shadow->x() + blurAndSpread);

@@ -1285,7 +1285,7 @@ void RenderStyle::getShadowVerticalExtent(const ShadowData* shadow, LayoutUnit &

for ( ; shadow; shadow = shadow->next()) {

if (shadow->style() == Inset)

continue;

- int blurAndSpread = shadow->blur() + shadow->spread();

+ LayoutUnit blurAndSpread = shadow->blur() + shadow->spread();

top = min<LayoutUnit>(top, shadow->y() - blurAndSpread);

bottom = max<LayoutUnit>(bottom, shadow->y() + blurAndSpread);