chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc - Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)

Patch Set: Less explosions Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/debugger/debugger_api.cc ('K') | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.h » ('j') | chrome/browser/extensions/api/tabs/tabs_event_router.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc b/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

index 52639e12c40e9c9d6dd5b88b67153dd882d6a964..8bac214f744d76c4ea517354ca8bc2a514a2f2f8 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

@@ -179,10 +179,11 @@ void DeveloperPrivateApiUnitTest::TestExtensionPrefSetting(

new api::DeveloperPrivateUpdateExtensionConfigurationFunction());

base::ListValue args;

- base::DictionaryValue* parameters = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> parameters(

+ new base::DictionaryValue());

parameters->SetString("extensionId", extension_id);

parameters->SetBoolean(key, true);

- args.Append(parameters);

+ args.Append(std::move(parameters));

EXPECT_FALSE(has_pref.Run()) << key;