Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5136)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.h

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)
Patch Set: Less explosions Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc ('K') | « chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | chrome/browser/extensions/api/tabs/tabs_event_router.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/downloads/downloads_api.h
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.h b/chrome/browser/extensions/api/downloads/downloads_api.h
index 71f4b3a5fb33b27843ba5ee5f7a03c981bfe62b5..6ad08a15c0d2bb8683a952096eb900aa36f1aa52 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.h
+++ b/chrome/browser/extensions/api/downloads/downloads_api.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_EXTENSIONS_API_DOWNLOADS_DOWNLOADS_API_H_
#define CHROME_BROWSER_EXTENSIONS_API_DOWNLOADS_DOWNLOADS_API_H_
+#include <memory>
#include <set>
#include <string>
@@ -388,7 +389,7 @@ class ExtensionDownloadsEventRouter
const std::string& event_name,
bool include_incognito,
const extensions::Event::WillDispatchCallback& will_dispatch_callback,
- base::Value* json_arg);
+ std::unique_ptr<base::Value> json_arg);
// extensions::ExtensionRegistryObserver.
void OnExtensionUnloaded(
« chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc ('K') | « chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | chrome/browser/extensions/api/tabs/tabs_event_router.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698