Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2323963002: Implement an event-based simulator for QuicConnection (Closed)

Created:
4 years, 3 months ago by ianswett
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Victor Vasiliev
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement an event-based simulator for QuicConnection The simulator is meant to be used in a situations where the full logic of connection control (congestion control, loss detection, retransmission policy, ack policy) is required to properly test a scenario and an isolated unit test would risk of making unrealistic assumptions or would require too much machinery to drive. Merge internal change: 131774129 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Adding missing files. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2243 lines, -2 lines) Patch
A net/quic/core/congestion_control/simulation/BUILD View 1 1 chunk +88 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/README.md View 1 1 chunk +98 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/actor.h View 1 1 chunk +63 lines, -0 lines 1 comment Download
A net/quic/core/congestion_control/simulation/actor.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/alarm_factory.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/alarm_factory.cc View 1 1 chunk +75 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/link.h View 1 1 chunk +94 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/link.cc View 1 1 chunk +107 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/port.h View 1 1 chunk +60 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/port.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/queue.h View 1 1 chunk +54 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/queue.cc View 1 1 chunk +59 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/quic_endpoint.h View 1 1 chunk +154 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/quic_endpoint.cc View 1 1 chunk +252 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/quic_endpoint_test.cc View 1 1 chunk +138 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/simulator.h View 1 1 chunk +105 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/simulator.cc View 1 1 chunk +112 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/simulator_test.cc View 1 1 chunk +527 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/switch.h View 1 1 chunk +76 lines, -0 lines 0 comments Download
A net/quic/core/congestion_control/simulation/switch.cc View 1 1 chunk +80 lines, -0 lines 0 comments Download
M net/quic/core/quic_bandwidth.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +6 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2328433006 Patch 1

Messages

Total messages: 2 (0 generated)
ianswett
4 years, 3 months ago (2016-09-08 21:33:52 UTC) #1
Ryan Hamilton
4 years, 3 months ago (2016-09-08 21:45:45 UTC) #2 
lgtm, mod copyright which you can add in final if you wish

https://codereview.chromium.org/2323963002/diff/20001/net/quic/core/congestio...
File net/quic/core/congestion_control/simulation/actor.h (right):

https://codereview.chromium.org/2323963002/diff/20001/net/quic/core/congestio...
net/quic/core/congestion_control/simulation/actor.h:1: #ifndef
NET_QUIC_CORE_CONGESTION_CONTROL_SIMULATION_ACTOR_H_
I think you need to add the chrome license to each of these files (or else the
pre-submit will complain)

Powered by Google App Engine
This is Rietveld 408576698