Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 2323463002: [blink_gc_plugin] Complain about stack-allocated classes with GC bases, but not arbitrary non-stack… (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[blink_gc_plugin] Complain about stack-allocated classes with GC bases, but not arbitrary non-stack-allocated bases. BUG=644725 Committed: https://crrev.com/f06159b98aa70d663afdc22ea5e8c0ad0ca06bf2 Cr-Commit-Position: refs/heads/master@{#417845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -28 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp View 2 chunks +11 lines, -7 lines 0 comments Download
M tools/clang/blink_gc_plugin/DiagnosticsReporter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/DiagnosticsReporter.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/stack_allocated.h View 2 chunks +10 lines, -7 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/stack_allocated.txt View 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jbroman
PTAL. I'm not certain this is the right fix, but given the expansion of STACK_ALLOCATED's ...
4 years, 3 months ago (2016-09-09 15:53:42 UTC) #6
haraken
LGTM
4 years, 3 months ago (2016-09-09 16:03:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323463002/1
4 years, 3 months ago (2016-09-10 20:20:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-10 20:55:50 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 20:57:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f06159b98aa70d663afdc22ea5e8c0ad0ca06bf2
Cr-Commit-Position: refs/heads/master@{#417845}

Powered by Google App Engine
This is Rietveld 408576698