Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: tools/clang/blink_gc_plugin/DiagnosticsReporter.h

Issue 2323463002: [blink_gc_plugin] Complain about stack-allocated classes with GC bases, but not arbitrary non-stack… (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/DiagnosticsReporter.h
diff --git a/tools/clang/blink_gc_plugin/DiagnosticsReporter.h b/tools/clang/blink_gc_plugin/DiagnosticsReporter.h
index 5bb94d7dec28459b156b77347d9929496e3a321a..ae4fd008d9eb6b47e3a05b7145773a13d2b7bb9b 100644
--- a/tools/clang/blink_gc_plugin/DiagnosticsReporter.h
+++ b/tools/clang/blink_gc_plugin/DiagnosticsReporter.h
@@ -54,7 +54,7 @@ class DiagnosticsReporter {
RecordInfo* receiver);
void MissingFinalizeDispatch(const clang::FunctionDecl* dispatch,
RecordInfo* receiver);
- void DerivesNonStackAllocated(RecordInfo* info, BasePoint* base);
+ void StackAllocatedDerivesGarbageCollected(RecordInfo* info, BasePoint* base);
void ClassOverridesNew(RecordInfo* info, clang::CXXMethodDecl* newop);
void ClassDeclaresPureVirtualTrace(RecordInfo* info,
clang::CXXMethodDecl* trace);
@@ -107,7 +107,7 @@ class DiagnosticsReporter {
unsigned diag_virtual_and_manual_dispatch_;
unsigned diag_missing_trace_dispatch_;
unsigned diag_missing_finalize_dispatch_;
- unsigned diag_derives_non_stack_allocated_;
+ unsigned diag_stack_allocated_derives_gc_;
unsigned diag_class_overrides_new_;
unsigned diag_class_declares_pure_virtual_trace_;
unsigned diag_left_most_base_must_be_polymorphic_;
« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp ('k') | tools/clang/blink_gc_plugin/DiagnosticsReporter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698