[blink_gc_plugin] Complain about stack-allocated classes with GC bases, but not arbitrary non-stack…

tools/clang/blink_gc_plugin/DiagnosticsReporter.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "DiagnosticsReporter.h"
 
 using namespace clang;
 
 namespace {
 
@@ skipping 109 matching lines @@
 
 const char kBaseRequiresFinalizationNote[] =
     "[blink-gc] Base class %0 requiring finalization declared here:";
 
 const char kFieldRequiresFinalizationNote[] =
     "[blink-gc] Field %0 requiring finalization declared here:";
 
 const char kManualDispatchMethodNote[] =
     "[blink-gc] Manual dispatch %0 declared here:";
 
-const char kDerivesNonStackAllocated[] =
+const char kStackAllocatedDerivesGarbageCollected[] =
     "[blink-gc] Stack-allocated class %0 derives class %1"
-    " which is not stack allocated.";
+    " which is garbage collected.";
 
 const char kClassOverridesNew[] =
     "[blink-gc] Garbage collected class %0"
     " is not permitted to override its new operator.";
 
 const char kClassDeclaresPureVirtualTrace[] =
     "[blink-gc] Garbage collected class %0"
     " is not permitted to declare a pure-virtual trace method.";
 
 const char kLeftMostBaseMustBePolymorphic[] =
@@ skipping 47 matching lines @@
   diag_missing_trace_dispatch_method_ = diagnostic_.getCustomDiagID(
       getErrorLevel(), kMissingTraceDispatchMethod);
   diag_missing_finalize_dispatch_method_ = diagnostic_.getCustomDiagID(
       getErrorLevel(), kMissingFinalizeDispatchMethod);
   diag_virtual_and_manual_dispatch_ =
       diagnostic_.getCustomDiagID(getErrorLevel(), kVirtualAndManualDispatch);
   diag_missing_trace_dispatch_ =
       diagnostic_.getCustomDiagID(getErrorLevel(), kMissingTraceDispatch);
   diag_missing_finalize_dispatch_ =
       diagnostic_.getCustomDiagID(getErrorLevel(), kMissingFinalizeDispatch);
-  diag_derives_non_stack_allocated_ =
-      diagnostic_.getCustomDiagID(getErrorLevel(), kDerivesNonStackAllocated);
+  diag_stack_allocated_derives_gc_ = diagnostic_.getCustomDiagID(
+      getErrorLevel(), kStackAllocatedDerivesGarbageCollected);
   diag_class_overrides_new_ =
       diagnostic_.getCustomDiagID(getErrorLevel(), kClassOverridesNew);
   diag_class_declares_pure_virtual_trace_ = diagnostic_.getCustomDiagID(
       getErrorLevel(), kClassDeclaresPureVirtualTrace);
   diag_left_most_base_must_be_polymorphic_ = diagnostic_.getCustomDiagID(
       getErrorLevel(), kLeftMostBaseMustBePolymorphic);
   diag_base_class_must_declare_virtual_trace_ = diagnostic_.getCustomDiagID(
       getErrorLevel(), kBaseClassMustDeclareVirtualTrace);
 
   // Register note messages.
@@ skipping 234 matching lines @@
   ReportMissingDispatch(dispatch, receiver, diag_missing_finalize_dispatch_);
 }
 
 void DiagnosticsReporter::ReportMissingDispatch(
     const FunctionDecl* dispatch,
     RecordInfo* receiver,
     unsigned error) {
   ReportDiagnostic(dispatch->getLocStart(), error) << receiver->record();
 }
 
-void DiagnosticsReporter::DerivesNonStackAllocated(
+void DiagnosticsReporter::StackAllocatedDerivesGarbageCollected(
     RecordInfo* info,
     BasePoint* base) {
   ReportDiagnostic(base->spec().getLocStart(),
-                   diag_derives_non_stack_allocated_)
+                   diag_stack_allocated_derives_gc_)
       << info->record() << base->info()->record();
 }
 
 void DiagnosticsReporter::ClassOverridesNew(
     RecordInfo* info,
     CXXMethodDecl* newop) {
   ReportDiagnostic(newop->getLocStart(), diag_class_overrides_new_)
       << info->record();
 }
 
@@ skipping 81 matching lines @@
 void DiagnosticsReporter::NoteField(FieldDecl* field, unsigned note) {
   ReportDiagnostic(field->getLocStart(), note) << field;
 }
 
 void DiagnosticsReporter::NoteOverriddenNonVirtualTrace(
     CXXMethodDecl* overridden) {
   ReportDiagnostic(overridden->getLocStart(),
                    diag_overridden_non_virtual_trace_note_)
       << overridden;
 }