ozone: Rename XKeyboard to KeyboardController & use fake under ozone

ozone: Rename XKeyboard to ImeKeyboard & use fake under ozone

This fixes some build errors for the "chromeos=1 use_ozone=1" build. We
need to generalize this X11 interface for controlling the system keyboard
for use under ozone.

This currently forces ozone builds to use the fake implementation, which
merely fixes the build. We still need to implement an ozone version.

BUG=361341
TEST=chrome --ozone-platform=test
TBR=derat, sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263219

[sadrul, 2014-04-10 00:16:57]

https://codereview.chromium.org/232333002/diff/1/chromeos/ime/keyboard_contro...
File chromeos/ime/keyboard_controller.h (right):

https://codereview.chromium.org/232333002/diff/1/chromeos/ime/keyboard_contro...
chromeos/ime/keyboard_controller.h:37: class CHROMEOS_EXPORT KeyboardController
{
There's a KeyboardController in ui/keyboard/. Can you call this something else
to not be confusing?

[spang, 2014-04-10 00:18:47]

https://codereview.chromium.org/232333002/diff/1/chromeos/ime/keyboard_contro...
File chromeos/ime/keyboard_controller.h (right):

https://codereview.chromium.org/232333002/diff/1/chromeos/ime/keyboard_contro...
chromeos/ime/keyboard_controller.h:37: class CHROMEOS_EXPORT KeyboardController
{
On 2014/04/10 00:16:57, sadrul wrote:
> There's a KeyboardController in ui/keyboard/. Can you call this something else
> to not be confusing?

Happy to bikeshed.

IMEKeyboardController?

NonVirtualKeyboardController?

SystemKeyboardController?

[Yuki, 2014-04-10 05:23:19]

Looks good to me, but please follow Sadrul's suggestion for the new name.

It's optional, but it's great if you could rename variable names, too.
For example, xkeyboard_ to blahblah_keyboard_controller_.

[spang, 2014-04-10 19:08:09]

On 2014/04/10 05:23:19, Yuki wrote:
> Looks good to me, but please follow Sadrul's suggestion for the new name.
> 
> It's optional, but it's great if you could rename variable names, too.
> For example, xkeyboard_ to blahblah_keyboard_controller_.

Done. It's now "ImeKeyboard", reflecting that it is defined in the IME code.

Also renamed variables from "xkeyboard" to "keyboard".

[Yuki, 2014-04-11 04:45:09]

lgtm

[spang, 2014-04-11 04:50:47]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-04-11 04:52:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/spang@chromium.org/232333002/20001

[spang, 2014-04-11 04:53:07]

The CQ bit was unchecked by spang@chromium.org

[spang, 2014-04-11 04:53:27]

The CQ bit was checked by spang@chromium.org

[spang, 2014-04-11 06:11:16]

The CQ bit was unchecked by spang@chromium.org

[spang, 2014-04-11 06:11:29]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-04-11 13:25:56]

Change committed as 263219