Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl.cc

Issue 232333002: ozone: Rename XKeyboard to KeyboardController & use fake under ozone (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename to ImeKeyboard & rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_manager_impl.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
index 45588b63a0c4cae807c17b481e75084afec23a73..09c0be01299d558adbf05cdc52abd34ae2f2507b 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
@@ -23,9 +23,9 @@
#include "chrome/browser/chromeos/language_preferences.h"
#include "chromeos/ime/component_extension_ime_manager.h"
#include "chromeos/ime/extension_ime_util.h"
-#include "chromeos/ime/fake_xkeyboard.h"
+#include "chromeos/ime/fake_ime_keyboard.h"
+#include "chromeos/ime/ime_keyboard.h"
#include "chromeos/ime/input_method_delegate.h"
-#include "chromeos/ime/xkeyboard.h"
#include "third_party/icu/source/common/unicode/uloc.h"
#include "ui/base/accelerators/accelerator.h"
@@ -393,7 +393,7 @@ bool InputMethodManagerImpl::ChangeInputMethodInternal(
}
// Change the keyboard layout to a preferred layout for the input method.
- if (!xkeyboard_->SetCurrentKeyboardLayoutByName(
+ if (!keyboard_->SetCurrentKeyboardLayoutByName(
current_input_method_.GetPreferredKeyboardLayout())) {
LOG(ERROR) << "Failed to change keyboard layout to "
<< current_input_method_.GetPreferredKeyboardLayout();
@@ -716,15 +716,15 @@ InputMethodDescriptor InputMethodManagerImpl::GetCurrentInputMethod() const {
}
bool InputMethodManagerImpl::IsISOLevel5ShiftUsedByCurrentInputMethod() const {
- return xkeyboard_->IsISOLevel5ShiftAvailable();
+ return keyboard_->IsISOLevel5ShiftAvailable();
}
bool InputMethodManagerImpl::IsAltGrUsedByCurrentInputMethod() const {
- return xkeyboard_->IsAltGrAvailable();
+ return keyboard_->IsAltGrAvailable();
}
-XKeyboard* InputMethodManagerImpl::GetXKeyboard() {
- return xkeyboard_.get();
+ImeKeyboard* InputMethodManagerImpl::GetImeKeyboard() {
+ return keyboard_.get();
}
InputMethodUtil* InputMethodManagerImpl::GetInputMethodUtil() {
@@ -751,9 +751,9 @@ void InputMethodManagerImpl::Init(base::SequencedTaskRunner* ui_task_runner) {
DCHECK(thread_checker_.CalledOnValidThread());
if (base::SysInfo::IsRunningOnChromeOS())
- xkeyboard_.reset(XKeyboard::Create());
+ keyboard_.reset(ImeKeyboard::Create());
else
- xkeyboard_.reset(new FakeXKeyboard());
+ keyboard_.reset(new FakeImeKeyboard());
// We can't call impl->Initialize here, because file thread is not available
// at this moment.
@@ -769,8 +769,8 @@ void InputMethodManagerImpl::SetCandidateWindowControllerForTesting(
candidate_window_controller_->AddObserver(this);
}
-void InputMethodManagerImpl::SetXKeyboardForTesting(XKeyboard* xkeyboard) {
- xkeyboard_.reset(xkeyboard);
+void InputMethodManagerImpl::SetImeKeyboardForTesting(ImeKeyboard* keyboard) {
+ keyboard_.reset(keyboard);
}
void InputMethodManagerImpl::InitializeComponentExtensionForTesting(

Powered by Google App Engine
This is Rietveld 408576698