[LayoutNG] Update NGLayoutInputText

[LayoutNG] Update NGLayoutInputText

Update NGLayoutInputText to include further fields for run segmentation.

BUG=591099
R=drott@chromium.org

Committed: https://crrev.com/1a379b6ecf0b694e1dfe17e9364f3b3ca19bcc0d
Cr-Commit-Position: refs/heads/master@{#417567}

[eae, 2016-09-09 11:03:30]

Description was changed from

==========
[LayoutNG] Update NGLayoutInputText

Update NGLayoutInputText to include further fields for run segmentation
in the layout input tree.

BUG=591099
R=drott@chromium.org
==========

to

==========
[LayoutNG] Update NGLayoutInputText

Update NGLayoutInputText to include further fields for run segmentation.

BUG=591099
R=drott@chromium.org
==========

[eae, 2016-09-09 11:03:36]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 11:03:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2016-09-09 11:11:21]

Thanks for codifying the result of our discussion. Comments below.

https://codereview.chromium.org/2323283002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_layout_input_text.h (right):

https://codereview.chromium.org/2323283002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_layout_input_text.h:22: // content
segmented by style, text direction, writing mode and script (but not
See below.

https://codereview.chromium.org/2323283002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_layout_input_text.h:30:
NGWritingMode writing_mode;
Rather than NGWritingMode this probably should represent the "should we rotate
the canvas for painting this run of text, e.g. latin in Japanese mixed. So the
values should reflect RenderOrientation
{
        OrientationKeep,
        OrientationRotateSideways
} from OrientationIterator.
And probably also the emoji segmentation result should be here.

So that eventually NGLayoutInputTextItem contains all the output of what
RunSegmenter currently does.

[drott, 2016-09-09 11:17:55]

LGTM with nit, pls update the comment accordingly.

[eae, 2016-09-09 11:19:23]

The CQ bit was checked by eae@chromium.org

[eae, 2016-09-09 11:19:24]

The patchset sent to the CQ was uploaded after l-g-t-m from drott@chromium.org
Link to the patchset: https://codereview.chromium.org/2323283002/#ps40001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-09-09 11:19:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 12:59:06]

Description was changed from

==========
[LayoutNG] Update NGLayoutInputText

Update NGLayoutInputText to include further fields for run segmentation.

BUG=591099
R=drott@chromium.org
==========

to

==========
[LayoutNG] Update NGLayoutInputText

Update NGLayoutInputText to include further fields for run segmentation.

BUG=591099
R=drott@chromium.org
==========

[commit-bot: I haz the power, 2016-09-09 12:59:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-09 13:00:47]

Description was changed from

==========
[LayoutNG] Update NGLayoutInputText

Update NGLayoutInputText to include further fields for run segmentation.

BUG=591099
R=drott@chromium.org
==========

to

==========
[LayoutNG] Update NGLayoutInputText

Update NGLayoutInputText to include further fields for run segmentation.

BUG=591099
R=drott@chromium.org

Committed: https://crrev.com/1a379b6ecf0b694e1dfe17e9364f3b3ca19bcc0d
Cr-Commit-Position: refs/heads/master@{#417567}
==========

[commit-bot: I haz the power, 2016-09-09 13:00:48]

Patchset 3 (id:??) landed as
https://crrev.com/1a379b6ecf0b694e1dfe17e9364f3b3ca19bcc0d
Cr-Commit-Position: refs/heads/master@{#417567}