Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2322733002: Remove DCHECK from the component updater background downloader code. (Closed)

Created:
4 years, 3 months ago by Sorin Jianu
Modified:
4 years, 3 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DCHECK from the component updater background downloader code. The threading issue needs to be fixed according to crbug.com/644857 R=waffles BUG=644854 Committed: https://crrev.com/c1210527860aafd4b24f0b91b9934ed19eac4aac Cr-Commit-Position: refs/heads/master@{#417103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/update_client/background_downloader_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Sorin Jianu
4 years, 3 months ago (2016-09-07 21:51:24 UTC) #2
waffles
lgtm
4 years, 3 months ago (2016-09-07 21:52:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322733002/1
4 years, 3 months ago (2016-09-07 22:37:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 22:42:24 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:45:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1210527860aafd4b24f0b91b9934ed19eac4aac
Cr-Commit-Position: refs/heads/master@{#417103}

Powered by Google App Engine
This is Rietveld 408576698