Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: components/update_client/background_downloader_win.cc

Issue 2322733002: Remove DCHECK from the component updater background downloader code. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/update_client/background_downloader_win.h" 5 #include "components/update_client/background_downloader_win.h"
6 6
7 #include <atlbase.h> 7 #include <atlbase.h>
8 #include <atlcom.h> 8 #include <atlcom.h>
9 #include <stddef.h> 9 #include <stddef.h>
10 10
11 #include <stdint.h> 11 #include <stdint.h>
12 #include <functional> 12 #include <functional>
13 #include <iomanip> 13 #include <iomanip>
14 #include <limits> 14 #include <limits>
15 #include <memory>
15 #include <utility> 16 #include <utility>
16 #include <vector> 17 #include <vector>
17 18
18 #include "base/bind.h" 19 #include "base/bind.h"
19 #include "base/bind_helpers.h" 20 #include "base/bind_helpers.h"
20 #include "base/files/file_util.h" 21 #include "base/files/file_util.h"
21 #include "base/location.h" 22 #include "base/location.h"
22 #include "base/macros.h" 23 #include "base/macros.h"
23 #include "base/sequenced_task_runner.h" 24 #include "base/sequenced_task_runner.h"
24 #include "base/strings/sys_string_conversions.h" 25 #include "base/strings/sys_string_conversions.h"
(...skipping 841 matching lines...) Expand 10 before | Expand all | Expand 10 after
866 ScopedComPtr<IGlobalInterfaceTable> git; 867 ScopedComPtr<IGlobalInterfaceTable> git;
867 HRESULT hr = GetGit(&git); 868 HRESULT hr = GetGit(&git);
868 if (FAILED(hr)) 869 if (FAILED(hr))
869 return hr; 870 return hr;
870 871
871 const DWORD cookies[] = { 872 const DWORD cookies[] = {
872 git_cookie_job_, git_cookie_bits_manager_ 873 git_cookie_job_, git_cookie_bits_manager_
873 }; 874 };
874 875
875 for (auto cookie : cookies) { 876 for (auto cookie : cookies) {
876 hr = git->RevokeInterfaceFromGlobal(cookie); 877 // TODO(sorin): check the result of the call, see crbug.com/644857.
877 DCHECK(SUCCEEDED(hr)); 878 git->RevokeInterfaceFromGlobal(cookie);
878 } 879 }
879 880
880 return S_OK; 881 return S_OK;
881 } 882 }
882 883
883 } // namespace update_client 884 } // namespace update_client
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698